2018-04-11 20:09:53

by Laura Abbott

Subject: [PATCHv2] objtool: Support HOSTCFLAGS and HOSTLDFLAGS

It may be useful to compile host programs with different flags (e.g.
hardening). Ensure that objtool picks up the appropriate flags.

Signed-off-by: Laura Abbott <[email protected]>
---
v2: Drop several flags that are already defined in HOSTCFLAGS
---
tools/objtool/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
index e6acc281dd37..7df979ae4573 100644
--- a/tools/objtool/Makefile
+++ b/tools/objtool/Makefile
@@ -31,8 +31,8 @@ INCLUDES := -I$(srctree)/tools/include \
-I$(srctree)/tools/arch/$(HOSTARCH)/include/uapi \
-I$(srctree)/tools/objtool/arch/$(ARCH)/include
WARNINGS := $(EXTRA_WARNINGS) -Wno-switch-default -Wno-switch-enum -Wno-packed
-CFLAGS += -Wall -Werror $(WARNINGS) -fomit-frame-pointer -O2 -g $(INCLUDES)
-LDFLAGS += -lelf $(LIBSUBCMD)
+CFLAGS += -Werror $(WARNINGS) $(HOSTCFLAGS) -g $(INCLUDES)
+LDFLAGS += -lelf $(LIBSUBCMD) $(HOSTLDFLAGS)

# Allow old libelf to be used:
elfshdr := $(shell echo '\#include <libelf.h>' | $(CC) $(CFLAGS) -x c -E - | grep elf_getshdr)
--
2.14.3

2018-04-12 13:22:43

by Josh Poimboeuf

Subject: Re: [PATCHv2] objtool: Support HOSTCFLAGS and HOSTLDFLAGS

On Wed, Apr 11, 2018 at 01:04:32PM -0700, Laura Abbott wrote:
> It may be useful to compile host programs with different flags (e.g.
> hardening). Ensure that objtool picks up the appropriate flags.
>
> Signed-off-by: Laura Abbott <[email protected]>
> ---
> v2: Drop several flags that are already defined in HOSTCFLAGS

Thanks Laura. Changes to the objtool makefile usually go through the
-tip tree, so I'll run it through some testing and then send it along.

--
Josh