Add a description that the kernel headers should be used as far as it is
possible and then the system headers.
Signed-off-by: Anders Roxell <[email protected]>
---
Documentation/dev-tools/kselftest.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
index e80850eefe13..27f08d6ba91c 100644
--- a/Documentation/dev-tools/kselftest.rst
+++ b/Documentation/dev-tools/kselftest.rst
@@ -151,6 +151,9 @@ Contributing new tests (details)
TEST_FILES, TEST_GEN_FILES mean it is the file which is used by
test.
+ * First use the headers inside the kernel, and then the system headers. The
+ internal headers should be the primary focus to be able to find regressions.
+
Test Harness
============
--
2.11.0
On 04/17/2018 02:46 AM, Anders Roxell wrote:
> Add a description that the kernel headers should be used as far as it is
> possible and then the system headers.
>
> Signed-off-by: Anders Roxell <[email protected]>
> ---
> Documentation/dev-tools/kselftest.rst | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
> index e80850eefe13..27f08d6ba91c 100644
> --- a/Documentation/dev-tools/kselftest.rst
> +++ b/Documentation/dev-tools/kselftest.rst
> @@ -151,6 +151,9 @@ Contributing new tests (details)
> TEST_FILES, TEST_GEN_FILES mean it is the file which is used by
> test.
>
> + * First use the headers inside the kernel, and then the system headers. The
> + internal headers should be the primary focus to be able to find regressions.
Clarifying the location of the headers might be helpful. This description uses
different terminology to describe kernel headers.
"First use the headers inside the kernel sources and/or git reo" would make this
clear. Instead of "internal headers" headers for the kernel release as opposed
to headers installed by the distro on the system would make a clear distinction.
thanks,
-- Shuah
Add a description that the kernel headers should be used as far as it is
possible and then the system headers.
Signed-off-by: Anders Roxell <[email protected]>
---
Documentation/dev-tools/kselftest.rst | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
index e80850eefe13..3bf371a938d0 100644
--- a/Documentation/dev-tools/kselftest.rst
+++ b/Documentation/dev-tools/kselftest.rst
@@ -151,6 +151,11 @@ Contributing new tests (details)
TEST_FILES, TEST_GEN_FILES mean it is the file which is used by
test.
+ * First use the headers inside the kernel source and/or git repo, and then the
+ system headers. Headers for the kernel release as opposed to headers
+ installed by the distro on the system should be the primary focus to be able
+ to find regressions.
+
Test Harness
============
--
2.11.0
On 04/19/2018 04:28 AM, Anders Roxell wrote:
> Add a description that the kernel headers should be used as far as it is
> possible and then the system headers.
>
> Signed-off-by: Anders Roxell <[email protected]>
> ---
> Documentation/dev-tools/kselftest.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
> index e80850eefe13..3bf371a938d0 100644
> --- a/Documentation/dev-tools/kselftest.rst
> +++ b/Documentation/dev-tools/kselftest.rst
> @@ -151,6 +151,11 @@ Contributing new tests (details)
> TEST_FILES, TEST_GEN_FILES mean it is the file which is used by
> test.
>
> + * First use the headers inside the kernel source and/or git repo, and then the
> + system headers. Headers for the kernel release as opposed to headers
> + installed by the distro on the system should be the primary focus to be able
> + to find regressions.
> +
> Test Harness
> ============
>
>
Here is my reviewed by for this to go through documentation tree.
Reviewed-by: Shuah Khan (Samsung OSG) <[email protected]>
thanks,
-- Shuah
On Thu, 19 Apr 2018 12:28:25 +0200
Anders Roxell <[email protected]> wrote:
> Add a description that the kernel headers should be used as far as it is
> possible and then the system headers.
>
> Signed-off-by: Anders Roxell <[email protected]>
Applied, thanks.
jon