2018-04-24 14:03:23

by Luc Van Oostenryck

Subject: [PATCH] cpufreq: fix speedstep_detect_processor()'s return type

speedstep_detect_processor() is declared as returing an
'enum speedstep_processor' but use an 'int' in its definition.

Fix this by using 'enum speedstep_processor' in its definition too.

Signed-off-by: Luc Van Oostenryck <[email protected]>
---
drivers/cpufreq/speedstep-lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/speedstep-lib.c b/drivers/cpufreq/speedstep-lib.c
index e3a9962ee..cabb6f48e 100644
--- a/drivers/cpufreq/speedstep-lib.c
+++ b/drivers/cpufreq/speedstep-lib.c
@@ -252,7 +252,7 @@ EXPORT_SYMBOL_GPL(speedstep_get_frequency);
*********************************************************************/

/* Keep in sync with the x86_cpu_id tables in the different modules */
-unsigned int speedstep_detect_processor(void)
+enum speedstep_processor speedstep_detect_processor(void)
{
struct cpuinfo_x86 *c = &cpu_data(0);
u32 ebx, msr_lo, msr_hi;
--
2.17.0

2018-04-25 02:51:04

by Viresh Kumar

Subject: Re: [PATCH] cpufreq: fix speedstep_detect_processor()'s return type

On 24-04-18, 15:14, Luc Van Oostenryck wrote:
> speedstep_detect_processor() is declared as returing an
> 'enum speedstep_processor' but use an 'int' in its definition.
>
> Fix this by using 'enum speedstep_processor' in its definition too.
>
> Signed-off-by: Luc Van Oostenryck <[email protected]>
> ---
> drivers/cpufreq/speedstep-lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/speedstep-lib.c b/drivers/cpufreq/speedstep-lib.c
> index e3a9962ee..cabb6f48e 100644
> --- a/drivers/cpufreq/speedstep-lib.c
> +++ b/drivers/cpufreq/speedstep-lib.c
> @@ -252,7 +252,7 @@ EXPORT_SYMBOL_GPL(speedstep_get_frequency);
> *********************************************************************/
>
> /* Keep in sync with the x86_cpu_id tables in the different modules */
> -unsigned int speedstep_detect_processor(void)
> +enum speedstep_processor speedstep_detect_processor(void)
> {
> struct cpuinfo_x86 *c = &cpu_data(0);
> u32 ebx, msr_lo, msr_hi;

Acked-by: Viresh Kumar <[email protected]>

--
viresh

2018-05-13 08:50:26

by Rafael J. Wysocki

Subject: Re: [PATCH] cpufreq: fix speedstep_detect_processor()'s return type

On Wednesday, April 25, 2018 4:46:47 AM CEST Viresh Kumar wrote:
> On 24-04-18, 15:14, Luc Van Oostenryck wrote:
> > speedstep_detect_processor() is declared as returing an
> > 'enum speedstep_processor' but use an 'int' in its definition.
> >
> > Fix this by using 'enum speedstep_processor' in its definition too.
> >
> > Signed-off-by: Luc Van Oostenryck <[email protected]>
> > ---
> > drivers/cpufreq/speedstep-lib.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/speedstep-lib.c b/drivers/cpufreq/speedstep-lib.c
> > index e3a9962ee..cabb6f48e 100644
> > --- a/drivers/cpufreq/speedstep-lib.c
> > +++ b/drivers/cpufreq/speedstep-lib.c
> > @@ -252,7 +252,7 @@ EXPORT_SYMBOL_GPL(speedstep_get_frequency);
> > *********************************************************************/
> >
> > /* Keep in sync with the x86_cpu_id tables in the different modules */
> > -unsigned int speedstep_detect_processor(void)
> > +enum speedstep_processor speedstep_detect_processor(void)
> > {
> > struct cpuinfo_x86 *c = &cpu_data(0);
> > u32 ebx, msr_lo, msr_hi;
>
> Acked-by: Viresh Kumar <[email protected]>
>
>

Applied, thanks!