2018-04-26 03:01:04

by Baolin Wang

Subject: [PATCH 1/2] rtc: sprd: Change to use devm_rtc_allocate_device()

This is a preparation patch, changing to use devm_rtc_allocate_device()
that can allow driver to set 'range_max' and 'range_min' for the RTC
device.

Signed-off-by: Baolin Wang <[email protected]>
---
drivers/rtc/rtc-sc27xx.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/rtc/rtc-sc27xx.c b/drivers/rtc/rtc-sc27xx.c
index 00d87d1..ac86322 100644
--- a/drivers/rtc/rtc-sc27xx.c
+++ b/drivers/rtc/rtc-sc27xx.c
@@ -600,6 +600,10 @@ static int sprd_rtc_probe(struct platform_device *pdev)
return rtc->irq;
}

+ rtc->rtc = devm_rtc_allocate_device(&pdev->dev);
+ if (IS_ERR(rtc->rtc))
+ return PTR_ERR(rtc->rtc);
+
rtc->dev = &pdev->dev;
platform_set_drvdata(pdev, rtc);

@@ -626,10 +630,12 @@ static int sprd_rtc_probe(struct platform_device *pdev)
return ret;
}

- rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
- &sprd_rtc_ops, THIS_MODULE);
- if (IS_ERR(rtc->rtc))
- return PTR_ERR(rtc->rtc);
+ rtc->rtc->ops = &sprd_rtc_ops;
+ ret = rtc_register_device(rtc->rtc);
+ if (ret) {
+ dev_err(&pdev->dev, "failed to register rtc device\n");
+ return ret;
+ }

device_init_wakeup(&pdev->dev, 1);
return 0;
--
1.7.9.5

2018-04-26 03:01:08

by Baolin Wang

Subject: [PATCH 2/2] rtc: sprd: Add RTC hardware range

The SC27xx RTC can support dates from 1970-01-01 00:00:00 to 2149-06-06
23:59:59.

Signed-off-by: Baolin Wang <[email protected]>
---
drivers/rtc/rtc-sc27xx.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/rtc/rtc-sc27xx.c b/drivers/rtc/rtc-sc27xx.c
index ac86322..6a3876e 100644
--- a/drivers/rtc/rtc-sc27xx.c
+++ b/drivers/rtc/rtc-sc27xx.c
@@ -631,6 +631,8 @@ static int sprd_rtc_probe(struct platform_device *pdev)
}

rtc->rtc->ops = &sprd_rtc_ops;
+ rtc->rtc->range_min = 0;
+ rtc->rtc->range_max = 5662310399LL;
ret = rtc_register_device(rtc->rtc);
if (ret) {
dev_err(&pdev->dev, "failed to register rtc device\n");
--
1.7.9.5

2018-05-03 20:13:04

by Alexandre Belloni

Subject: Re: [PATCH 1/2] rtc: sprd: Change to use devm_rtc_allocate_device()

On 26/04/2018 10:58:44+0800, Baolin Wang wrote:
> This is a preparation patch, changing to use devm_rtc_allocate_device()
> that can allow driver to set 'range_max' and 'range_min' for the RTC
> device.
>
> Signed-off-by: Baolin Wang <[email protected]>
> ---
> drivers/rtc/rtc-sc27xx.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>

Both applied, thanks.

--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com