2018-04-08 13:01:41

by sumeet p

[permalink] [raw]
Subject: [PATCH] thermal: tegra: soctherm: add const to struct thermal_cooling_device_ops

From: srp linux <[email protected]>

Correct the typecast with const to struct thermal_cooling_device_ops.
It is the last argument to the function thermal_of_cooling_device_register
and this argument is of type const. So, declare this structure
thermal_cooling_device_ops as constant.

Signed-off-by: srp linux <[email protected]>
---
drivers/thermal/tegra/soctherm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
index 455b58c..72da745 100644
--- a/drivers/thermal/tegra/soctherm.c
+++ b/drivers/thermal/tegra/soctherm.c
@@ -926,7 +926,7 @@ static int throt_set_cdev_state(struct thermal_cooling_device *cdev,
return 0;
}

-static struct thermal_cooling_device_ops throt_cooling_ops = {
+static const struct thermal_cooling_device_ops throt_cooling_ops = {
.get_max_state = throt_get_cdev_max_state,
.get_cur_state = throt_get_cdev_cur_state,
.set_cur_state = throt_set_cdev_state,
--
2.7.4



2018-04-09 11:59:29

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] thermal: tegra: soctherm: add const to struct thermal_cooling_device_ops

On Sun, Apr 08, 2018 at 05:31:45PM +0530, srplinux2008 wrote:
> From: srp linux <[email protected]>

Looks like you haven't properly set up git. Try setting your real name
using:

$ git config user.name 'Your Name'

> Correct the typecast with const to struct thermal_cooling_device_ops.
> It is the last argument to the function thermal_of_cooling_device_register
> and this argument is of type const. So, declare this structure
> thermal_cooling_device_ops as constant.
>
> Signed-off-by: srp linux <[email protected]>
> ---
> drivers/thermal/tegra/soctherm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Thierry Reding <[email protected]>

Attachments:
(No filename) (697.00 B)
 signature.asc (849.00 B)
 Download all attachments

2018-05-06 22:51:37

by Eduardo Valentin

[permalink] [raw]
Subject: Re: [PATCH] thermal: tegra: soctherm: add const to struct thermal_cooling_device_ops

On Sun, Apr 08, 2018 at 05:31:45PM +0530, srplinux2008 wrote:
> From: srp linux <[email protected]>
>
> Correct the typecast with const to struct thermal_cooling_device_ops.
> It is the last argument to the function thermal_of_cooling_device_register
> and this argument is of type const. So, declare this structure
> thermal_cooling_device_ops as constant.
>
> Signed-off-by: srp linux <[email protected]>

Please resend with your real name.

Thanks

> ---
> drivers/thermal/tegra/soctherm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
> index 455b58c..72da745 100644
> --- a/drivers/thermal/tegra/soctherm.c
> +++ b/drivers/thermal/tegra/soctherm.c
> @@ -926,7 +926,7 @@ static int throt_set_cdev_state(struct thermal_cooling_device *cdev,
> return 0;
> }
>
> -static struct thermal_cooling_device_ops throt_cooling_ops = {
> +static const struct thermal_cooling_device_ops throt_cooling_ops = {
> .get_max_state = throt_get_cdev_max_state,
> .get_cur_state = throt_get_cdev_cur_state,
> .set_cur_state = throt_set_cdev_state,
> --
> 2.7.4
>