2018-05-02 21:21:29

by Shuah Khan

Subject: [PATCH] selftests: futex: delete RUN_TESTS and EMIT_TESTS overrides

Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
lib.mk. Common defines work just fine and there is no need to define
custom overrides.

Signed-off-by: Shuah Khan (Samsung OSG) <[email protected]>
---
tools/testing/selftests/futex/Makefile | 12 ------------
1 file changed, 12 deletions(-)

diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
index 8497a376ef9d..12631f0076a1 100644
--- a/tools/testing/selftests/futex/Makefile
+++ b/tools/testing/selftests/futex/Makefile
@@ -17,14 +17,6 @@ all:
fi \
done

-override define RUN_TESTS
- @export KSFT_TAP_LEVEL=`echo 1`;
- @echo "TAP version 13";
- @echo "selftests: futex";
- @echo "========================================";
- @cd $(OUTPUT); ./run.sh
-endef
-
override define INSTALL_RULE
mkdir -p $(INSTALL_PATH)
install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)
@@ -36,10 +28,6 @@ override define INSTALL_RULE
done;
endef

-override define EMIT_TESTS
- echo "./run.sh"
-endef
-
override define CLEAN
@for DIR in $(SUBDIRS); do \
BUILD_TARGET=$(OUTPUT)/$$DIR; \
--
2.14.1

2018-05-09 10:17:33

by Anders Roxell

Subject: Re: [PATCH] selftests: futex: delete RUN_TESTS and EMIT_TESTS overrides

On 2018-05-02 15:18, Shuah Khan (Samsung OSG) wrote:
> Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
> lib.mk. Common defines work just fine and there is no need to define
> custom overrides.
>
> Signed-off-by: Shuah Khan (Samsung OSG) <[email protected]>

Reviewed-by: Anders Roxell <[email protected]>

> ---
> tools/testing/selftests/futex/Makefile | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index 8497a376ef9d..12631f0076a1 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -17,14 +17,6 @@ all:
> fi \
> done
>
> -override define RUN_TESTS
> - @export KSFT_TAP_LEVEL=`echo 1`;
> - @echo "TAP version 13";
> - @echo "selftests: futex";
> - @echo "========================================";
> - @cd $(OUTPUT); ./run.sh
> -endef
> -
> override define INSTALL_RULE
> mkdir -p $(INSTALL_PATH)
> install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)
> @@ -36,10 +28,6 @@ override define INSTALL_RULE
> done;
> endef
>
> -override define EMIT_TESTS
> - echo "./run.sh"
> -endef
> -
> override define CLEAN
> @for DIR in $(SUBDIRS); do \
> BUILD_TARGET=$(OUTPUT)/$$DIR; \
> --
> 2.14.1
>

2018-05-11 15:13:57

by Darren Hart

Subject: Re: [PATCH] selftests: futex: delete RUN_TESTS and EMIT_TESTS overrides

On Wed, May 02, 2018 at 03:18:45PM -0600, Shuah Khan (Samsung OSG) wrote:
> Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
> lib.mk. Common defines work just fine and there is no need to define
> custom overrides.
>
> Signed-off-by: Shuah Khan (Samsung OSG) <[email protected]>

I was concerned because this override was a deliberate decision made in:

9705315b7562 selftests/futex: Update Makefile to use lib.mk

But reviewing lib.mk today, the RUN_TESTS and EMIT_TESTS perform the same
function running TEST_PROGS.

Reviewed-by: Darren Hart (VMware) <[email protected]>

--
Darren Hart
VMware Open Source Technology Center

2018-05-11 15:25:59

by Shuah Khan

Subject: Re: [PATCH] selftests: futex: delete RUN_TESTS and EMIT_TESTS overrides

On 05/11/2018 09:13 AM, Darren Hart wrote:
> On Wed, May 02, 2018 at 03:18:45PM -0600, Shuah Khan (Samsung OSG) wrote:
>> Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
>> lib.mk. Common defines work just fine and there is no need to define
>> custom overrides.
>>
>> Signed-off-by: Shuah Khan (Samsung OSG) <[email protected]>
>
> I was concerned because this override was a deliberate decision made in:
>
> 9705315b7562 selftests/futex: Update Makefile to use lib.mk

Yes I had the same concern.
>
> But reviewing lib.mk today, the RUN_TESTS and EMIT_TESTS perform the same
> function running TEST_PROGS.
>
> Reviewed-by: Darren Hart (VMware) <[email protected]>
>

Thanks. Yes I was surprised as well. I ran a few times to make sure. :)

-- Shuah