2018-05-14 20:58:02

by Samuel Thibault

Subject: [PATCH] staging: speakup: use true/false instead of 1/0

Signed-off-by: Samuel Thibault <[email protected]>
---
drivers/staging/speakup/buffers.c | 2 +-
drivers/staging/speakup/main.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/staging/speakup/buffers.c
+++ b/drivers/staging/speakup/buffers.c
@@ -80,7 +80,7 @@ void synth_buffer_add(u16 ch)
/* We have written something to the speech synthesis, so we are not
* paused any more.
*/
- spk_paused = 0;
+ spk_paused = false;
}

u16 synth_buffer_getc(void)
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -1784,7 +1784,7 @@ static void speakup_con_update(struct vc
speakup_date(vc);
if (vc->vc_mode == KD_GRAPHICS && !spk_paused && spk_str_pause[0]) {
synth_printf("%s", spk_str_pause);
- spk_paused = 1;
+ spk_paused = true;
}
spin_unlock_irqrestore(&speakup_info.spinlock, flags);
}

2018-05-15 12:03:28

by Dan Carpenter

Subject: Re: [PATCH] staging: speakup: use true/false instead of 1/0

On Mon, May 14, 2018 at 10:57:25PM +0200, Samuel Thibault wrote:
> Signed-off-by: Samuel Thibault <[email protected]>

Greg doesn't accept patches without a commit message. Just say which
tool warned for example.

regards,
dan carpenter