2018-05-16 21:37:45

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Signed-off-by missing for commits in the v4l-dvb tree

Hi Mauro,

Commit

af76c93aa36d ("media: cadence: csi2rx: Fix csi2rx_start error handling")

is missing a Signed-off-by from its committer.

Commits

c578c7710712 ("media: imx258: Add imx258 camera sensor driver")
3a8fdc1426c3 ("media: dw9807: Add dw9807 vcm driver")
2f9c1c88369f ("media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil")

are missing a Signed-off-by from their author.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2018-05-17 07:18:26

by Sakari Ailus

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commits in the v4l-dvb tree

On Thu, May 17, 2018 at 07:37:02AM +1000, Stephen Rothwell wrote:
> Hi Mauro,
>
> Commit
>
> af76c93aa36d ("media: cadence: csi2rx: Fix csi2rx_start error handling")
>
> is missing a Signed-off-by from its committer.

Mauro's SoB line is indeed missing. I wonder what happened.

>
> Commits
>
> c578c7710712 ("media: imx258: Add imx258 camera sensor driver")
> 3a8fdc1426c3 ("media: dw9807: Add dw9807 vcm driver")
> 2f9c1c88369f ("media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil")
>
> are missing a Signed-off-by from their author.

Thanks for pointing this out. We'll be more careful going forward.

--
Regards,

Sakari Ailus
[email protected]

2018-05-17 10:06:24

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commits in the v4l-dvb tree

Em Thu, 17 May 2018 10:17:20 +0300
Sakari Ailus <[email protected]> escreveu:

> On Thu, May 17, 2018 at 07:37:02AM +1000, Stephen Rothwell wrote:
> > Hi Mauro,
> >
> > Commit
> >
> > af76c93aa36d ("media: cadence: csi2rx: Fix csi2rx_start error handling")
> >
> > is missing a Signed-off-by from its committer.
>
> Mauro's SoB line is indeed missing. I wonder what happened.
>
> >
> > Commits
> >
> > c578c7710712 ("media: imx258: Add imx258 camera sensor driver")
> > 3a8fdc1426c3 ("media: dw9807: Add dw9807 vcm driver")
> > 2f9c1c88369f ("media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil")
> >
> > are missing a Signed-off-by from their author.
>
> Thanks for pointing this out. We'll be more careful going forward.

In this specific case, we're adding two drivers without their
author's SOBs. I'll roll-back my tree to a sane state (and, while
there, add my SOB at the missing commit).

Sakari,

You'll need to resubmit those patches (and the dependent ones) once
you get the author's SOBs.

Thanks,
Mauro