2018-05-26 09:55:25

by Robert Jarzmik

Subject: [RESEND PATCH] dmaengine: pxa: add a default requestor policy

As what former drcmr -1 value meant, add a this as a default to each
channel, ie. that by default no requestor line is used.

This is specifically used for network drivers smc91x and smc911x, and
needed for their port to slave maps.

Cc: Arnd Bergmann <[email protected]>
Signed-off-by: Robert Jarzmik <[email protected]>
---
drivers/dma/pxa_dma.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c
index 9505334f9c6e..604df1bdadf7 100644
--- a/drivers/dma/pxa_dma.c
+++ b/drivers/dma/pxa_dma.c
@@ -762,6 +762,8 @@ static void pxad_free_chan_resources(struct dma_chan *dchan)
dma_pool_destroy(chan->desc_pool);
chan->desc_pool = NULL;

+ chan->drcmr = (u32)-1;
+ chan->prio = PXAD_PRIO_LOWEST;
}

static void pxad_free_desc(struct virt_dma_desc *vd)
@@ -1386,6 +1388,9 @@ static int pxad_init_dmadev(struct platform_device *op,
c = devm_kzalloc(&op->dev, sizeof(*c), GFP_KERNEL);
if (!c)
return -ENOMEM;
+
+ c->drcmr = (u32)-1;
+ c->prio = PXAD_PRIO_LOWEST;
c->vc.desc_free = pxad_free_desc;
vchan_init(&c->vc, &pdev->slave);
init_waitqueue_head(&c->wq_state);
--
2.11.0

2018-05-29 07:25:53

by Vinod Koul

Subject: Re: [RESEND PATCH] dmaengine: pxa: add a default requestor policy

On 26-05-18, 11:54, Robert Jarzmik wrote:
> @@ -762,6 +762,8 @@ static void pxad_free_chan_resources(struct dma_chan *dchan)
> dma_pool_destroy(chan->desc_pool);
> chan->desc_pool = NULL;
>
> + chan->drcmr = (u32)-1;

why not use U32_MAX for this?

--
~Vinod

2018-05-29 19:17:04

by Robert Jarzmik

Subject: Re: [RESEND PATCH] dmaengine: pxa: add a default requestor policy

Vinod <[email protected]> writes:

> On 26-05-18, 11:54, Robert Jarzmik wrote:
>> @@ -762,6 +762,8 @@ static void pxad_free_chan_resources(struct dma_chan *dchan)
>> dma_pool_destroy(chan->desc_pool);
>> chan->desc_pool = NULL;
>>
>> + chan->drcmr = (u32)-1;
>
> why not use U32_MAX for this?
But of course, anything else you see ?

Cheers.

--
Robert

2018-05-30 10:28:01

by Vinod Koul

Subject: Re: [RESEND PATCH] dmaengine: pxa: add a default requestor policy

On 29-05-18, 21:13, Robert Jarzmik wrote:
> Vinod <[email protected]> writes:
>
> > On 26-05-18, 11:54, Robert Jarzmik wrote:
> >> @@ -762,6 +762,8 @@ static void pxad_free_chan_resources(struct dma_chan *dchan)
> >> dma_pool_destroy(chan->desc_pool);
> >> chan->desc_pool = NULL;
> >>
> >> + chan->drcmr = (u32)-1;
> >
> > why not use U32_MAX for this?
> But of course, anything else you see ?

Nope that was the only one :)

--
~Vinod