2018-06-03 11:12:46

by Varsha Rao

Subject: [PATCH] net: ipw2x00: Replace NULL comparison with !priv

Remove extra parentheses and replace NULL comparison with !priv, to fix
clang warning of extraneous parentheses and check patch issue. Following
coccinelle script is used to fix it.

@disable is_null,paren@
expression e;
statement s;
@@
if (
- (e==NULL)
+!e
)
s

Signed-off-by: Varsha Rao <[email protected]>
---
drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
index 87a5e414c2f7..7d55bb09413b 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
@@ -7112,7 +7112,7 @@ static u32 ipw_qos_get_burst_duration(struct ipw_priv *priv)
{
u32 ret = 0;

- if ((priv == NULL))
+ if (!priv)
return 0;

if (!(priv->ieee->modulation & LIBIPW_OFDM_MODULATION))
--
2.17.0

2018-06-27 19:09:38

by Kalle Valo

Subject: Re: net: ipw2x00: Replace NULL comparison with !priv

Varsha Rao <[email protected]> wrote:

> Remove extra parentheses and replace NULL comparison with !priv, to fix
> clang warning of extraneous parentheses and check patch issue. Following
> coccinelle script is used to fix it.
>
> @disable is_null,paren@
> expression e;
> statement s;
> @@
> if (
> - (e==NULL)
> +!e
> )
> s
>
> Signed-off-by: Varsha Rao <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

4e5f881d430a net: ipw2x00: Replace NULL comparison with !priv

--
https://patchwork.kernel.org/patch/10445241/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches