2018-07-06 13:10:00

by Benjamin Gaignard

Subject: [PATCH] watchdog: stm32: replace "%p" with "%pK"

The format specifier "%p" can leak kernel addresses.
Use "%pK" instead.

Signed-off-by: Benjamin Gaignard <[email protected]>
---
drivers/watchdog/stm32_iwdg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c
index c97ad5619cb0..740f74a98644 100644
--- a/drivers/watchdog/stm32_iwdg.c
+++ b/drivers/watchdog/stm32_iwdg.c
@@ -172,7 +172,7 @@ static int stm32_iwdg_probe(struct platform_device *pdev)

ret = clk_prepare_enable(clk);
if (ret) {
- dev_err(&pdev->dev, "Unable to prepare clock %p\n", clk);
+ dev_err(&pdev->dev, "Unable to prepare clock %pK\n", clk);
return ret;
}

--
2.15.0

2018-07-07 21:29:01

by Guenter Roeck

Subject: Re: [PATCH] watchdog: stm32: replace "%p" with "%pK"

On Fri, Jul 06, 2018 at 03:08:08PM +0200, Benjamin Gaignard wrote:
> The format specifier "%p" can leak kernel addresses.
> Use "%pK" instead.
>
The pointer has zero value either way. If the clock has a name,
it might make sense to display it. Otherwise just drop the pointer.

Guenter

> Signed-off-by: Benjamin Gaignard <[email protected]>
> ---
> drivers/watchdog/stm32_iwdg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c
> index c97ad5619cb0..740f74a98644 100644
> --- a/drivers/watchdog/stm32_iwdg.c
> +++ b/drivers/watchdog/stm32_iwdg.c
> @@ -172,7 +172,7 @@ static int stm32_iwdg_probe(struct platform_device *pdev)
>
> ret = clk_prepare_enable(clk);
> if (ret) {
> - dev_err(&pdev->dev, "Unable to prepare clock %p\n", clk);
> + dev_err(&pdev->dev, "Unable to prepare clock %pK\n", clk);
> return ret;
> }
>
> --
> 2.15.0
>