2018-07-09 12:54:53

by Jaya Durga

Subject: [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse

From: root <[email protected]>

CHECK: Macro argument reuse 'gdm' - possible side-effects?

convert GDM_TTY_READY to gdm_tty_ready static function
to fix checkpath check

Signed-off-by: Jaya Durga <[email protected]>
---
drivers/staging/gdm724x/gdm_tty.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index bf554f7c56ca..5de1940c1f79 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -27,7 +27,11 @@
#define MUX_TX_MAX_SIZE 2048
-#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count)
+static unsigned int gdm_tty_ready(struct gdm *gdm)
+{
+return (gdm && gdm->tty_dev && gdm->port.count);
+}
+

static struct tty_driver *gdm_driver[TTY_MAX_COUNT];
static struct gdm *gdm_table[TTY_MAX_COUNT][GDM_TTY_MINOR];
@@ -127,7 +131,7 @@ static int gdm_tty_recv_complete(void *data,
{
struct gdm *gdm = tty_dev->gdm[index];
- if (!GDM_TTY_READY(gdm)) {
+ if (!gdm_tty_ready(gdm)) {
if (complete == RECV_PACKET_PROCESS_COMPLETE)
gdm->tty_dev->recv_func(gdm->tty_dev->priv_dev,
gdm_tty_recv_complete);
@@ -154,7 +158,7 @@ static void gdm_tty_send_complete(void *arg)
{
struct gdm *gdm = arg;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return;
tty_port_tty_wakeup(&gdm->port);
@@ -168,7 +172,7 @@ static int gdm_tty_write(struct tty_struct *tty, const unsigned char *buf,
int sent_len = 0;
int sending_len = 0;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return -ENODEV;
if (!len)
@@ -195,7 +199,7 @@ static int gdm_tty_write_room(struct tty_struct *tty)
{
struct gdm *gdm = tty->driver_data;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return -ENODEV;
return WRITE_SIZE;

2018-07-09 12:58:22

by Dan Carpenter

Subject: Re: [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse

I don't understand why you have sent this patch four times.

Are you a script which has a bug? Please answer us so that we know you
are a human being.

regards,
dan carpenter

2018-07-09 13:04:00

by Jaya Durga

Subject: Re: [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse

Hi ,
I have updated the patch --subject-prefix="PATCH v3" and made the
commit as per your suggestion ,
i don't know why does the script doesn't update my changes,will try to
sort out the issue ,
sorry for the inconvenience.

Regards,
Jaya Durga

On Mon, Jul 9, 2018 at 6:26 PM, Dan Carpenter <[email protected]> wrote:
> I don't understand why you have sent this patch four times.
>
> Are you a script which has a bug? Please answer us so that we know you
> are a human being.
>
> regards,
> dan carpenter
>