2018-07-12 04:11:38

by Luis Araneda

[permalink] [raw]
Subject: [PATCH v3 0/6] arm: dts: zynq: improvements and cleanup

This series attempts to standardize device naming and improve
its information for better identification

The values of the "compatible" and "model" device-tree properties
are corrected for some devices, adding complementary information
when necessary

Changes since v2:
- Split dt-bindings patch (too many changes)
- Apply dts patches first (reorder)

Changes since v1 (RFC):
- Add values to compatible property instead of replacing them
- Don't remove "internal" word from Xilinx boards on dt-bindings
- Migrate content of adapteva dt-binding file into Xilinx's
- Sort additional compatible strings alphabetically
by manufacturer
- Dropped patch that renamed the zedboard development board
(no apparent benefit)
- Dropped the patch that removed the "zynq" value from the
compatible strings (breaks the ABI)

Luis Araneda (6):
arm: dts: zynq: Set correct manufacturer for ZedBoard and MicroZed
boards
arm: dts: zynq: correct and improve the model property of dt files
dt-bindings: xilinx: zynq: Improve boards description
dt-bindings: xilinx: zynq: Sort entries alphabetically
dt-bindings: Move Paralella board to Xilinx
dt-bindings: xilinx: zynq: Add missing boards

.../devicetree/bindings/arm/adapteva.txt | 7 -----
.../devicetree/bindings/arm/xilinx.txt | 30 +++++++++++++++----
arch/arm/boot/dts/zynq-cc108.dts | 2 +-
arch/arm/boot/dts/zynq-microzed.dts | 4 +--
arch/arm/boot/dts/zynq-parallella.dts | 2 +-
arch/arm/boot/dts/zynq-zc702.dts | 2 +-
arch/arm/boot/dts/zynq-zc706.dts | 2 +-
arch/arm/boot/dts/zynq-zc770-xm010.dts | 2 +-
arch/arm/boot/dts/zynq-zc770-xm011.dts | 2 +-
arch/arm/boot/dts/zynq-zc770-xm012.dts | 2 +-
arch/arm/boot/dts/zynq-zc770-xm013.dts | 2 +-
arch/arm/boot/dts/zynq-zed.dts | 4 +--
arch/arm/boot/dts/zynq-zybo-z7.dts | 2 +-
arch/arm/boot/dts/zynq-zybo.dts | 2 +-
14 files changed, 39 insertions(+), 26 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/arm/adapteva.txt

--
2.18.0



2018-07-12 04:11:43

by Luis Araneda

[permalink] [raw]
Subject: [PATCH v3 1/6] arm: dts: zynq: Set correct manufacturer for ZedBoard and MicroZed boards

Both boards are made by Avnet, Inc. So add an additional
value to the compatible property

Signed-off-by: Luis Araneda <[email protected]>
---
arch/arm/boot/dts/zynq-microzed.dts | 2 +-
arch/arm/boot/dts/zynq-zed.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/zynq-microzed.dts b/arch/arm/boot/dts/zynq-microzed.dts
index aa4a0b6defb8..574ef2276182 100644
--- a/arch/arm/boot/dts/zynq-microzed.dts
+++ b/arch/arm/boot/dts/zynq-microzed.dts
@@ -8,7 +8,7 @@

/ {
model = "Zynq MicroZED Development Board";
- compatible = "xlnx,zynq-microzed", "xlnx,zynq-7000";
+ compatible = "avnet,zynq-microzed", "xlnx,zynq-microzed", "xlnx,zynq-7000";

aliases {
ethernet0 = &gem0;
diff --git a/arch/arm/boot/dts/zynq-zed.dts b/arch/arm/boot/dts/zynq-zed.dts
index 53c6883ce1f6..595022487965 100644
--- a/arch/arm/boot/dts/zynq-zed.dts
+++ b/arch/arm/boot/dts/zynq-zed.dts
@@ -8,7 +8,7 @@

/ {
model = "Zynq Zed Development Board";
- compatible = "xlnx,zynq-zed", "xlnx,zynq-7000";
+ compatible = "avnet,zynq-zed", "xlnx,zynq-zed", "xlnx,zynq-7000";

aliases {
ethernet0 = &gem0;
--
2.18.0


2018-07-12 04:11:51

by Luis Araneda

[permalink] [raw]
Subject: [PATCH v3 2/6] arm: dts: zynq: correct and improve the model property of dt files

Replace the current value of the model property by a more accurate
description of each board (which includes the manufacturer), as some
of the boards had the same value ("Xilinx Zynq")

Signed-off-by: Luis Araneda <[email protected]>
---
arch/arm/boot/dts/zynq-cc108.dts | 2 +-
arch/arm/boot/dts/zynq-microzed.dts | 2 +-
arch/arm/boot/dts/zynq-parallella.dts | 2 +-
arch/arm/boot/dts/zynq-zc702.dts | 2 +-
arch/arm/boot/dts/zynq-zc706.dts | 2 +-
arch/arm/boot/dts/zynq-zc770-xm010.dts | 2 +-
arch/arm/boot/dts/zynq-zc770-xm011.dts | 2 +-
arch/arm/boot/dts/zynq-zc770-xm012.dts | 2 +-
arch/arm/boot/dts/zynq-zc770-xm013.dts | 2 +-
arch/arm/boot/dts/zynq-zed.dts | 2 +-
arch/arm/boot/dts/zynq-zybo-z7.dts | 2 +-
arch/arm/boot/dts/zynq-zybo.dts | 2 +-
12 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/arch/arm/boot/dts/zynq-cc108.dts b/arch/arm/boot/dts/zynq-cc108.dts
index 1a0f631c1d8d..8b9ab9bba23b 100644
--- a/arch/arm/boot/dts/zynq-cc108.dts
+++ b/arch/arm/boot/dts/zynq-cc108.dts
@@ -12,8 +12,8 @@
/include/ "zynq-7000.dtsi"

/ {
+ model = "Xilinx CC108 board";
compatible = "xlnx,zynq-cc108", "xlnx,zynq-7000";
- model = "Xilinx Zynq";

aliases {
ethernet0 = &gem0;
diff --git a/arch/arm/boot/dts/zynq-microzed.dts b/arch/arm/boot/dts/zynq-microzed.dts
index 574ef2276182..6ed84fb15902 100644
--- a/arch/arm/boot/dts/zynq-microzed.dts
+++ b/arch/arm/boot/dts/zynq-microzed.dts
@@ -7,7 +7,7 @@
/include/ "zynq-7000.dtsi"

/ {
- model = "Zynq MicroZED Development Board";
+ model = "Avnet MicroZed board";
compatible = "avnet,zynq-microzed", "xlnx,zynq-microzed", "xlnx,zynq-7000";

aliases {
diff --git a/arch/arm/boot/dts/zynq-parallella.dts b/arch/arm/boot/dts/zynq-parallella.dts
index c05f4b67d4c1..54592aeb92b9 100644
--- a/arch/arm/boot/dts/zynq-parallella.dts
+++ b/arch/arm/boot/dts/zynq-parallella.dts
@@ -12,7 +12,7 @@
/include/ "zynq-7000.dtsi"

/ {
- model = "Adapteva Parallella Board";
+ model = "Adapteva Parallella board";
compatible = "adapteva,parallella", "xlnx,zynq-7000";

aliases {
diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts
index f2330b0cb63d..3f84b94db995 100644
--- a/arch/arm/boot/dts/zynq-zc702.dts
+++ b/arch/arm/boot/dts/zynq-zc702.dts
@@ -7,7 +7,7 @@
#include "zynq-7000.dtsi"

/ {
- model = "Zynq ZC702 Development Board";
+ model = "Xilinx ZC702 board";
compatible = "xlnx,zynq-zc702", "xlnx,zynq-7000";

aliases {
diff --git a/arch/arm/boot/dts/zynq-zc706.dts b/arch/arm/boot/dts/zynq-zc706.dts
index 3ad1260ff2a1..a15908cacbcf 100644
--- a/arch/arm/boot/dts/zynq-zc706.dts
+++ b/arch/arm/boot/dts/zynq-zc706.dts
@@ -7,7 +7,7 @@
#include "zynq-7000.dtsi"

/ {
- model = "Zynq ZC706 Development Board";
+ model = "Xilinx ZC706 board";
compatible = "xlnx,zynq-zc706", "xlnx,zynq-7000";

aliases {
diff --git a/arch/arm/boot/dts/zynq-zc770-xm010.dts b/arch/arm/boot/dts/zynq-zc770-xm010.dts
index 6884f1ad66b7..0e1bfdd3421f 100644
--- a/arch/arm/boot/dts/zynq-zc770-xm010.dts
+++ b/arch/arm/boot/dts/zynq-zc770-xm010.dts
@@ -8,8 +8,8 @@
#include "zynq-7000.dtsi"

/ {
+ model = "Xilinx ZC770 XM010 board";
compatible = "xlnx,zynq-zc770-xm010", "xlnx,zynq-7000";
- model = "Xilinx Zynq";

aliases {
ethernet0 = &gem0;
diff --git a/arch/arm/boot/dts/zynq-zc770-xm011.dts b/arch/arm/boot/dts/zynq-zc770-xm011.dts
index b78883cee96a..b7f65862c022 100644
--- a/arch/arm/boot/dts/zynq-zc770-xm011.dts
+++ b/arch/arm/boot/dts/zynq-zc770-xm011.dts
@@ -8,8 +8,8 @@
#include "zynq-7000.dtsi"

/ {
+ model = "Xilinx ZC770 XM011 board";
compatible = "xlnx,zynq-zc770-xm011", "xlnx,zynq-7000";
- model = "Xilinx Zynq";

aliases {
i2c0 = &i2c1;
diff --git a/arch/arm/boot/dts/zynq-zc770-xm012.dts b/arch/arm/boot/dts/zynq-zc770-xm012.dts
index c3169d63600d..d2359b789eb8 100644
--- a/arch/arm/boot/dts/zynq-zc770-xm012.dts
+++ b/arch/arm/boot/dts/zynq-zc770-xm012.dts
@@ -8,8 +8,8 @@
#include "zynq-7000.dtsi"

/ {
+ model = "Xilinx ZC770 XM012 board";
compatible = "xlnx,zynq-zc770-xm012", "xlnx,zynq-7000";
- model = "Xilinx Zynq";

aliases {
i2c0 = &i2c0;
diff --git a/arch/arm/boot/dts/zynq-zc770-xm013.dts b/arch/arm/boot/dts/zynq-zc770-xm013.dts
index 8bb66859d774..651913f1afa2 100644
--- a/arch/arm/boot/dts/zynq-zc770-xm013.dts
+++ b/arch/arm/boot/dts/zynq-zc770-xm013.dts
@@ -8,8 +8,8 @@
#include "zynq-7000.dtsi"

/ {
+ model = "Xilinx ZC770 XM013 board";
compatible = "xlnx,zynq-zc770-xm013", "xlnx,zynq-7000";
- model = "Xilinx Zynq";

aliases {
ethernet0 = &gem1;
diff --git a/arch/arm/boot/dts/zynq-zed.dts b/arch/arm/boot/dts/zynq-zed.dts
index 595022487965..3a4ae51ca4da 100644
--- a/arch/arm/boot/dts/zynq-zed.dts
+++ b/arch/arm/boot/dts/zynq-zed.dts
@@ -7,7 +7,7 @@
#include "zynq-7000.dtsi"

/ {
- model = "Zynq Zed Development Board";
+ model = "Avnet ZedBoard board";
compatible = "avnet,zynq-zed", "xlnx,zynq-zed", "xlnx,zynq-7000";

aliases {
diff --git a/arch/arm/boot/dts/zynq-zybo-z7.dts b/arch/arm/boot/dts/zynq-zybo-z7.dts
index 1e713dc98920..be40be9b7222 100644
--- a/arch/arm/boot/dts/zynq-zybo-z7.dts
+++ b/arch/arm/boot/dts/zynq-zybo-z7.dts
@@ -3,7 +3,7 @@
#include "zynq-7000.dtsi"

/ {
- model = "Zynq ZYBO Z7 Development Board";
+ model = "Digilent Zybo Z7 board";
compatible = "digilent,zynq-zybo-z7", "xlnx,zynq-7000";

aliases {
diff --git a/arch/arm/boot/dts/zynq-zybo.dts b/arch/arm/boot/dts/zynq-zybo.dts
index a6c00e7fa767..0439e9f1ea6f 100644
--- a/arch/arm/boot/dts/zynq-zybo.dts
+++ b/arch/arm/boot/dts/zynq-zybo.dts
@@ -7,7 +7,7 @@
#include "zynq-7000.dtsi"

/ {
- model = "Zynq ZYBO Development Board";
+ model = "Digilent Zybo board";
compatible = "digilent,zynq-zybo", "xlnx,zynq-7000";

aliases {
--
2.18.0


2018-07-12 04:11:53

by Luis Araneda

[permalink] [raw]
Subject: [PATCH v3 3/6] dt-bindings: xilinx: zynq: Improve boards description

Change the description of some boards to make it similar
to the value of the model property from their respective
device-tree, using the format "<manufacturer> <model>"

Signed-off-by: Luis Araneda <[email protected]>
---
Documentation/devicetree/bindings/arm/xilinx.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/xilinx.txt b/Documentation/devicetree/bindings/arm/xilinx.txt
index b9043bc35c14..4f1759b2bea7 100644
--- a/Documentation/devicetree/bindings/arm/xilinx.txt
+++ b/Documentation/devicetree/bindings/arm/xilinx.txt
@@ -8,10 +8,10 @@ Required root node properties:

Additional compatible strings:

-- Xilinx internal board cc108
+- Xilinx CC108 internal board
"xlnx,zynq-cc108"

-- Xilinx internal board zc770 with different FMC cards
+- Xilinx ZC770 internal board, with different FMC cards
"xlnx,zynq-zc770-xm010"
"xlnx,zynq-zc770-xm011"
"xlnx,zynq-zc770-xm012"
--
2.18.0


2018-07-12 04:11:54

by Luis Araneda

[permalink] [raw]
Subject: [PATCH v3 4/6] dt-bindings: xilinx: zynq: Sort entries alphabetically

Sort additional compatible strings (boards) alphabetically
by their manufacturer and model number

This will help when finding a board because they
will be grouped by their manufacturer

Signed-off-by: Luis Araneda <[email protected]>
---
Documentation/devicetree/bindings/arm/xilinx.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/xilinx.txt b/Documentation/devicetree/bindings/arm/xilinx.txt
index 4f1759b2bea7..a8e70a794d2e 100644
--- a/Documentation/devicetree/bindings/arm/xilinx.txt
+++ b/Documentation/devicetree/bindings/arm/xilinx.txt
@@ -8,6 +8,9 @@ Required root node properties:

Additional compatible strings:

+- Digilent Zybo Z7 board
+ "digilent,zynq-zybo-z7"
+
- Xilinx CC108 internal board
"xlnx,zynq-cc108"

@@ -17,9 +20,6 @@ Additional compatible strings:
"xlnx,zynq-zc770-xm012"
"xlnx,zynq-zc770-xm013"

-- Digilent Zybo Z7 board
- "digilent,zynq-zybo-z7"
-
---------------------------------------------------------------

Xilinx Zynq UltraScale+ MPSoC Platforms Device Tree Bindings
--
2.18.0


2018-07-12 04:11:57

by Luis Araneda

[permalink] [raw]
Subject: [PATCH v3 6/6] dt-bindings: xilinx: zynq: Add missing boards

The bindings were missing when the device-tree
files were added

Signed-off-by: Luis Araneda <[email protected]>
---
.../devicetree/bindings/arm/xilinx.txt | 17 +++++++++++++++++
1 file changed, 17 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/xilinx.txt b/Documentation/devicetree/bindings/arm/xilinx.txt
index d1a6deac90b5..26fe5ecc4332 100644
--- a/Documentation/devicetree/bindings/arm/xilinx.txt
+++ b/Documentation/devicetree/bindings/arm/xilinx.txt
@@ -11,12 +11,29 @@ Additional compatible strings:
- Adapteva Parallella board
"adapteva,parallella"

+- Avnet MicroZed board
+ "avnet,zynq-microzed"
+ "xlnx,zynq-microzed"
+
+- Avnet ZedBoard board
+ "avnet,zynq-zed"
+ "xlnx,zynq-zed"
+
+- Digilent Zybo board
+ "digilent,zynq-zybo"
+
- Digilent Zybo Z7 board
"digilent,zynq-zybo-z7"

- Xilinx CC108 internal board
"xlnx,zynq-cc108"

+- Xilinx ZC702 internal board
+ "xlnx,zynq-zc702"
+
+- Xilinx ZC706 internal board
+ "xlnx,zynq-zc706"
+
- Xilinx ZC770 internal board, with different FMC cards
"xlnx,zynq-zc770-xm010"
"xlnx,zynq-zc770-xm011"
--
2.18.0


2018-07-12 04:12:03

by Luis Araneda

[permalink] [raw]
Subject: [PATCH v3 5/6] dt-bindings: Move Paralella board to Xilinx

Move the Adapteva Parallela board to Xilinx dt-bindings,
as it's based on a Zynq SoC from Xilinx

Signed-off-by: Luis Araneda <[email protected]>
---
Documentation/devicetree/bindings/arm/adapteva.txt | 7 -------
Documentation/devicetree/bindings/arm/xilinx.txt | 3 +++
2 files changed, 3 insertions(+), 7 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/arm/adapteva.txt

diff --git a/Documentation/devicetree/bindings/arm/adapteva.txt b/Documentation/devicetree/bindings/arm/adapteva.txt
deleted file mode 100644
index 1d8af9e36065..000000000000
--- a/Documentation/devicetree/bindings/arm/adapteva.txt
+++ /dev/null
@@ -1,7 +0,0 @@
-Adapteva Platforms Device Tree Bindings
----------------------------------------
-
-Parallella board
-
-Required root node properties:
- - compatible = "adapteva,parallella";
diff --git a/Documentation/devicetree/bindings/arm/xilinx.txt b/Documentation/devicetree/bindings/arm/xilinx.txt
index a8e70a794d2e..d1a6deac90b5 100644
--- a/Documentation/devicetree/bindings/arm/xilinx.txt
+++ b/Documentation/devicetree/bindings/arm/xilinx.txt
@@ -8,6 +8,9 @@ Required root node properties:

Additional compatible strings:

+- Adapteva Parallella board
+ "adapteva,parallella"
+
- Digilent Zybo Z7 board
"digilent,zynq-zybo-z7"

--
2.18.0


2018-07-16 15:34:45

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v3 3/6] dt-bindings: xilinx: zynq: Improve boards description

On Thu, Jul 12, 2018 at 12:10:21AM -0400, Luis Araneda wrote:
> Change the description of some boards to make it similar
> to the value of the model property from their respective
> device-tree, using the format "<manufacturer> <model>"
>
> Signed-off-by: Luis Araneda <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/xilinx.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Rob Herring <[email protected]>

2018-07-16 15:35:03

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v3 4/6] dt-bindings: xilinx: zynq: Sort entries alphabetically

On Thu, Jul 12, 2018 at 12:10:22AM -0400, Luis Araneda wrote:
> Sort additional compatible strings (boards) alphabetically
> by their manufacturer and model number
>
> This will help when finding a board because they
> will be grouped by their manufacturer
>
> Signed-off-by: Luis Araneda <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/xilinx.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Rob Herring <[email protected]>


2018-07-16 15:35:35

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v3 5/6] dt-bindings: Move Paralella board to Xilinx

On Thu, Jul 12, 2018 at 12:10:23AM -0400, Luis Araneda wrote:
> Move the Adapteva Parallela board to Xilinx dt-bindings,
> as it's based on a Zynq SoC from Xilinx
>
> Signed-off-by: Luis Araneda <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/adapteva.txt | 7 -------
> Documentation/devicetree/bindings/arm/xilinx.txt | 3 +++
> 2 files changed, 3 insertions(+), 7 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/adapteva.txt

Reviewed-by: Rob Herring <[email protected]>

2018-07-16 15:37:04

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v3 6/6] dt-bindings: xilinx: zynq: Add missing boards

On Thu, Jul 12, 2018 at 12:10:24AM -0400, Luis Araneda wrote:
> The bindings were missing when the device-tree
> files were added
>
> Signed-off-by: Luis Araneda <[email protected]>
> ---
> .../devicetree/bindings/arm/xilinx.txt | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)

Reviewed-by: Rob Herring <[email protected]>

2018-07-17 14:26:04

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH v3 0/6] arm: dts: zynq: improvements and cleanup

On 12.7.2018 06:10, Luis Araneda wrote:
> This series attempts to standardize device naming and improve
> its information for better identification
>
> The values of the "compatible" and "model" device-tree properties
> are corrected for some devices, adding complementary information
> when necessary
>
> Changes since v2:
> - Split dt-bindings patch (too many changes)
> - Apply dts patches first (reorder)
>
> Changes since v1 (RFC):
> - Add values to compatible property instead of replacing them
> - Don't remove "internal" word from Xilinx boards on dt-bindings
> - Migrate content of adapteva dt-binding file into Xilinx's
> - Sort additional compatible strings alphabetically
> by manufacturer
> - Dropped patch that renamed the zedboard development board
> (no apparent benefit)
> - Dropped the patch that removed the "zynq" value from the
> compatible strings (breaks the ABI)
>
> Luis Araneda (6):
> arm: dts: zynq: Set correct manufacturer for ZedBoard and MicroZed
> boards
> arm: dts: zynq: correct and improve the model property of dt files
> dt-bindings: xilinx: zynq: Improve boards description
> dt-bindings: xilinx: zynq: Sort entries alphabetically
> dt-bindings: Move Paralella board to Xilinx
> dt-bindings: xilinx: zynq: Add missing boards
>
> .../devicetree/bindings/arm/adapteva.txt | 7 -----
> .../devicetree/bindings/arm/xilinx.txt | 30 +++++++++++++++----
> arch/arm/boot/dts/zynq-cc108.dts | 2 +-
> arch/arm/boot/dts/zynq-microzed.dts | 4 +--
> arch/arm/boot/dts/zynq-parallella.dts | 2 +-
> arch/arm/boot/dts/zynq-zc702.dts | 2 +-
> arch/arm/boot/dts/zynq-zc706.dts | 2 +-
> arch/arm/boot/dts/zynq-zc770-xm010.dts | 2 +-
> arch/arm/boot/dts/zynq-zc770-xm011.dts | 2 +-
> arch/arm/boot/dts/zynq-zc770-xm012.dts | 2 +-
> arch/arm/boot/dts/zynq-zc770-xm013.dts | 2 +-
> arch/arm/boot/dts/zynq-zed.dts | 4 +--
> arch/arm/boot/dts/zynq-zybo-z7.dts | 2 +-
> arch/arm/boot/dts/zynq-zybo.dts | 2 +-
> 14 files changed, 39 insertions(+), 26 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/adapteva.txt
>

Applied all.

Thanks,
Michal