2018-07-16 22:59:49

by David Lechner

Subject: [PATCH] net: usb: rtl8150: demote allmulti message to dev_dbg()

This driver can spam the kernel log with multiple messages of:

net eth0: eth0: allmulti set

Usually 4 or 8 at a time (probably because of using ConnMan).

This message doesn't seem useful, so let's demote it from dev_info()
to dev_dbg().

Signed-off-by: David Lechner <[email protected]>
---
drivers/net/usb/rtl8150.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
index 0e81d4c441d9..80373a9171dd 100644
--- a/drivers/net/usb/rtl8150.c
+++ b/drivers/net/usb/rtl8150.c
@@ -682,7 +682,7 @@ static void rtl8150_set_multicast(struct net_device *netdev)
(netdev->flags & IFF_ALLMULTI)) {
rx_creg &= 0xfffe;
rx_creg |= 0x0002;
- dev_info(&netdev->dev, "%s: allmulti set\n", netdev->name);
+ dev_dbg(&netdev->dev, "%s: allmulti set\n", netdev->name);
} else {
/* ~RX_MULTICAST, ~RX_PROMISCUOUS */
rx_creg &= 0x00fc;
--
2.17.1

2018-07-18 06:11:03

by David Miller

Subject: Re: [PATCH] net: usb: rtl8150: demote allmulti message to dev_dbg()

From: David Lechner <[email protected]>
Date: Mon, 16 Jul 2018 17:58:10 -0500

> This driver can spam the kernel log with multiple messages of:
>
> net eth0: eth0: allmulti set
>
> Usually 4 or 8 at a time (probably because of using ConnMan).
>
> This message doesn't seem useful, so let's demote it from dev_info()
> to dev_dbg().
>
> Signed-off-by: David Lechner <[email protected]>

Applied, thanks David.