2018-07-17 01:08:16

by kernel test robot

Subject: [RFC PATCH net-next] net: mvpp2: mvpp2_flow_get_hek_fields() can be static

Fixes: d33ec4525007 ("net: mvpp2: add an RSS classification step for each flow")
Signed-off-by: kbuild test robot <[email protected]>
---
mvpp2_cls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
index 723d0ba..fc9ec51 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
@@ -618,7 +618,7 @@ static int mvpp2_port_rss_hash_opts_set(struct mvpp2_port *port, int flow_type,
return 0;
}

-u16 mvpp2_flow_get_hek_fields(struct mvpp2_cls_flow_entry *fe)
+static u16 mvpp2_flow_get_hek_fields(struct mvpp2_cls_flow_entry *fe)
{
u16 hash_opts = 0;
int n_fields, i, field;

2018-07-17 07:39:30

by Maxime Chevallier

Subject: Re: [RFC PATCH net-next] net: mvpp2: mvpp2_flow_get_hek_fields() can be static

Hi,

On Tue, 17 Jul 2018 09:18:12 +0800
kbuild test robot <[email protected]> wrote:

>Fixes: d33ec4525007 ("net: mvpp2: add an RSS classification step for each flow")
>Signed-off-by: kbuild test robot <[email protected]>
>---
> mvpp2_cls.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
>index 723d0ba..fc9ec51 100644
>--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
>+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
>@@ -618,7 +618,7 @@ static int mvpp2_port_rss_hash_opts_set(struct mvpp2_port *port, int flow_type,
> return 0;
> }
>
>-u16 mvpp2_flow_get_hek_fields(struct mvpp2_cls_flow_entry *fe)
>+static u16 mvpp2_flow_get_hek_fields(struct mvpp2_cls_flow_entry *fe)
> {
> u16 hash_opts = 0;
> int n_fields, i, field;

That was a valid patch since it seems I forgot to make
another function static in the RSS series.

However this function is used in debugfs, so this patch isn't valid
anymore.

Sorry about that, but please don't apply this.

Thanks,

Maxime

--
Maxime Chevallier, Bootlin (formerly Free Electrons)
Embedded Linux and kernel engineering
https://bootlin.com