2018-07-18 21:59:05

by Lyude Paul

Subject: [PATCH] drm/print: Fix DRM_DEBUG_DP macro

This isn't supposed to take dev as an argument, I guess no one noticed!

Signed-off-by: Lyude Paul <[email protected]>
---
include/drm/drm_print.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index 767c90b654c5..fc08584a5101 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -310,7 +310,7 @@ void drm_err(const char *format, ...);

#define DRM_DEV_DEBUG_DP(dev, fmt, ...) \
drm_dev_dbg(dev, DRM_UT_DP, fmt, ## __VA_ARGS__)
-#define DRM_DEBUG_DP(dev, fmt, ...) \
+#define DRM_DEBUG_DP(fmt, ...) \
drm_dbg(DRM_UT_DP, fmt, ## __VA_ARGS__)

#define _DRM_DEV_DEFINE_DEBUG_RATELIMITED(dev, category, fmt, ...) \
--
2.17.1

2018-07-18 23:09:14

by Rodrigo Vivi

Subject: Re: [PATCH] drm/print: Fix DRM_DEBUG_DP macro

On Wed, Jul 18, 2018 at 05:57:16PM -0400, Lyude Paul wrote:
> This isn't supposed to take dev as an argument, I guess no one noticed!

Apparently no one using it... Why don't we just kill it?

>
> Signed-off-by: Lyude Paul <[email protected]>

anyways, if you prefer to keep or have plans to use:

Reviewed-by: Rodrigo Vivi <[email protected]>


> ---
> include/drm/drm_print.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
> index 767c90b654c5..fc08584a5101 100644
> --- a/include/drm/drm_print.h
> +++ b/include/drm/drm_print.h
> @@ -310,7 +310,7 @@ void drm_err(const char *format, ...);
>
> #define DRM_DEV_DEBUG_DP(dev, fmt, ...) \
> drm_dev_dbg(dev, DRM_UT_DP, fmt, ## __VA_ARGS__)
> -#define DRM_DEBUG_DP(dev, fmt, ...) \
> +#define DRM_DEBUG_DP(fmt, ...) \
> drm_dbg(DRM_UT_DP, fmt, ## __VA_ARGS__)
>
> #define _DRM_DEV_DEFINE_DEBUG_RATELIMITED(dev, category, fmt, ...) \
> --
> 2.17.1
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

2018-07-18 23:10:32

by Lyude Paul

Subject: Re: [PATCH] drm/print: Fix DRM_DEBUG_DP macro

On Wed, 2018-07-18 at 16:07 -0700, Rodrigo Vivi wrote:
> On Wed, Jul 18, 2018 at 05:57:16PM -0400, Lyude Paul wrote:
> > This isn't supposed to take dev as an argument, I guess no one noticed!
>
> Apparently no one using it... Why don't we just kill it?

Yeah-I've got plans to hopefully use this at some point in the future
>
> >
> > Signed-off-by: Lyude Paul <[email protected]>
>
> anyways, if you prefer to keep or have plans to use:
>
> Reviewed-by: Rodrigo Vivi <[email protected]>
>
>
> > ---
> > include/drm/drm_print.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
> > index 767c90b654c5..fc08584a5101 100644
> > --- a/include/drm/drm_print.h
> > +++ b/include/drm/drm_print.h
> > @@ -310,7 +310,7 @@ void drm_err(const char *format, ...);
> >
> > #define DRM_DEV_DEBUG_DP(dev, fmt, ...)
> > \
> > drm_dev_dbg(dev, DRM_UT_DP, fmt, ## __VA_ARGS__)
> > -#define DRM_DEBUG_DP(dev, fmt, ...)
> > \
> > +#define DRM_DEBUG_DP(fmt, ...)
> > \
> > drm_dbg(DRM_UT_DP, fmt, ## __VA_ARGS__)
> >
> > #define _DRM_DEV_DEFINE_DEBUG_RATELIMITED(dev, category, fmt, ...)
> > \
> > --
> > 2.17.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > [email protected]
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Cheers,
Lyude Paul