2018-07-24 09:38:25

by Arnd Bergmann

Subject: [PATCH] media: platform: cros-ec-cec: fix dependency on MFD_CROS_EC

Without the MFD driver, we run into a link error:

drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_transmit':
cros-ec-cec.c:(.text+0x474): undefined reference to `cros_ec_cmd_xfer_status'
drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_set_log_addr':
cros-ec-cec.c:(.text+0x60b): undefined reference to `cros_ec_cmd_xfer_status'
drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_adap_enable':
cros-ec-cec.c:(.text+0x77d): undefined reference to `cros_ec_cmd_xfer_status'

As we can compile-test all the dependency, the extra '| COMPILE_TEST' is
not needed to get the build coverage, and we can simply turn MFD_CROS_EC
into a hard dependency to make it build in all configurations.

Fixes: cd70de2d356e ("media: platform: Add ChromeOS EC CEC driver")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/media/platform/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index 92b182da8e4d..018fcbed82e4 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -535,7 +535,7 @@ if CEC_PLATFORM_DRIVERS

config VIDEO_CROS_EC_CEC
tristate "ChromeOS EC CEC driver"
- depends on MFD_CROS_EC || COMPILE_TEST
+ depends on MFD_CROS_EC
select CEC_CORE
select CEC_NOTIFIER
---help---
--
2.18.0

2018-08-02 23:00:00

by Mauro Carvalho Chehab

Subject: Re: [PATCH] media: platform: cros-ec-cec: fix dependency on MFD_CROS_EC

Em Tue, 24 Jul 2018 11:35:59 +0200
Arnd Bergmann <[email protected]> escreveu:

> Without the MFD driver, we run into a link error:

Weird... I'm not seeing this driver at the media tree... was it merged via
some other tree?

>
> drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_transmit':
> cros-ec-cec.c:(.text+0x474): undefined reference to `cros_ec_cmd_xfer_status'
> drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_set_log_addr':
> cros-ec-cec.c:(.text+0x60b): undefined reference to `cros_ec_cmd_xfer_status'
> drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_adap_enable':
> cros-ec-cec.c:(.text+0x77d): undefined reference to `cros_ec_cmd_xfer_status'
>
> As we can compile-test all the dependency, the extra '| COMPILE_TEST' is
> not needed to get the build coverage, and we can simply turn MFD_CROS_EC
> into a hard dependency to make it build in all configurations.
>
> Fixes: cd70de2d356e ("media: platform: Add ChromeOS EC CEC driver")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/media/platform/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index 92b182da8e4d..018fcbed82e4 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -535,7 +535,7 @@ if CEC_PLATFORM_DRIVERS
>
> config VIDEO_CROS_EC_CEC
> tristate "ChromeOS EC CEC driver"
> - depends on MFD_CROS_EC || COMPILE_TEST
> + depends on MFD_CROS_EC
> select CEC_CORE
> select CEC_NOTIFIER
> ---help---



Thanks,
Mauro

2018-08-03 06:31:37

by Hans Verkuil

Subject: Re: [PATCH] media: platform: cros-ec-cec: fix dependency on MFD_CROS_EC

On 08/03/2018 12:58 AM, Mauro Carvalho Chehab wrote:
> Em Tue, 24 Jul 2018 11:35:59 +0200
> Arnd Bergmann <[email protected]> escreveu:
>
>> Without the MFD driver, we run into a link error:
>
> Weird... I'm not seeing this driver at the media tree... was it merged via
> some other tree?

Yes, it's going via the mfd subsystem. This driver touched on the mfd, drm and
media subsystems, in the end it was decided to let the mfd subsystem take this
since it had the most impact on that subsystem.

Regards,

Hans

>
>>
>> drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_transmit':
>> cros-ec-cec.c:(.text+0x474): undefined reference to `cros_ec_cmd_xfer_status'
>> drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_set_log_addr':
>> cros-ec-cec.c:(.text+0x60b): undefined reference to `cros_ec_cmd_xfer_status'
>> drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_adap_enable':
>> cros-ec-cec.c:(.text+0x77d): undefined reference to `cros_ec_cmd_xfer_status'
>>
>> As we can compile-test all the dependency, the extra '| COMPILE_TEST' is
>> not needed to get the build coverage, and we can simply turn MFD_CROS_EC
>> into a hard dependency to make it build in all configurations.
>>
>> Fixes: cd70de2d356e ("media: platform: Add ChromeOS EC CEC driver")
>> Signed-off-by: Arnd Bergmann <[email protected]>
>> ---
>> drivers/media/platform/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
>> index 92b182da8e4d..018fcbed82e4 100644
>> --- a/drivers/media/platform/Kconfig
>> +++ b/drivers/media/platform/Kconfig
>> @@ -535,7 +535,7 @@ if CEC_PLATFORM_DRIVERS
>>
>> config VIDEO_CROS_EC_CEC
>> tristate "ChromeOS EC CEC driver"
>> - depends on MFD_CROS_EC || COMPILE_TEST
>> + depends on MFD_CROS_EC
>> select CEC_CORE
>> select CEC_NOTIFIER
>> ---help---
>
>
>
> Thanks,
> Mauro
>