2018-08-07 11:36:43

by Yue Haibing

Subject: [PATCH net-next] RDS: IB: fix 'passing zero to ERR_PTR()' warning

Fix a static code checker warning:
net/rds/ib_frmr.c:82 rds_ib_alloc_frmr() warn: passing zero to 'ERR_PTR'

The error path for ib_alloc_mr failure should set err to PTR_ERR.

Fixes: 1659185fb4d0 ("RDS: IB: Support Fastreg MR (FRMR) memory registration mode")
Signed-off-by: YueHaibing <[email protected]>
---
net/rds/ib_frmr.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/rds/ib_frmr.c b/net/rds/ib_frmr.c
index b371cf0..6431a02 100644
--- a/net/rds/ib_frmr.c
+++ b/net/rds/ib_frmr.c
@@ -61,6 +61,7 @@ static struct rds_ib_mr *rds_ib_alloc_frmr(struct rds_ib_device *rds_ibdev,
pool->fmr_attr.max_pages);
if (IS_ERR(frmr->mr)) {
pr_warn("RDS/IB: %s failed to allocate MR", __func__);
+ err = PTR_ERR(frmr->mr);
goto out_no_cigar;
}

--
2.7.0

2018-08-07 17:11:07

by Santosh Shilimkar

Subject: Re: [PATCH net-next] RDS: IB: fix 'passing zero to ERR_PTR()' warning

On 8/7/2018 4:34 AM, YueHaibing wrote:
> Fix a static code checker warning:
> net/rds/ib_frmr.c:82 rds_ib_alloc_frmr() warn: passing zero to 'ERR_PTR'
>
> The error path for ib_alloc_mr failure should set err to PTR_ERR.
>
> Fixes: 1659185fb4d0 ("RDS: IB: Support Fastreg MR (FRMR) memory registration mode")
> Signed-off-by: YueHaibing <[email protected]>
> ---
Looks good. Thanks !!

Acked-by: Santosh Shilimkar <[email protected]>

2018-08-07 20:22:00

by David Miller

Subject: Re: [PATCH net-next] RDS: IB: fix 'passing zero to ERR_PTR()' warning

From: YueHaibing <[email protected]>
Date: Tue, 7 Aug 2018 19:34:16 +0800

> Fix a static code checker warning:
> net/rds/ib_frmr.c:82 rds_ib_alloc_frmr() warn: passing zero to 'ERR_PTR'
>
> The error path for ib_alloc_mr failure should set err to PTR_ERR.
>
> Fixes: 1659185fb4d0 ("RDS: IB: Support Fastreg MR (FRMR) memory registration mode")
> Signed-off-by: YueHaibing <[email protected]>

Applied to net-next, thanks.