2018-08-28 16:54:10

by Michal Kubecek

Subject: [PATCH net-next] genetlink: constify genl_err_attr() argument

genl_err_attr() sets netlink_ext_ack::bad_attr which is a pointer to const
struct nlattr so make the attr argument also const.

Signed-off-by: Michal Kubecek <[email protected]>
---
include/net/genetlink.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/genetlink.h b/include/net/genetlink.h
index decf6012a401..aa2e5888f18d 100644
--- a/include/net/genetlink.h
+++ b/include/net/genetlink.h
@@ -112,7 +112,7 @@ static inline void genl_info_net_set(struct genl_info *info, struct net *net)
#define GENL_SET_ERR_MSG(info, msg) NL_SET_ERR_MSG((info)->extack, msg)

static inline int genl_err_attr(struct genl_info *info, int err,
- struct nlattr *attr)
+ const struct nlattr *attr)
{
info->extack->bad_attr = attr;

--
2.18.0

2018-08-30 02:44:23

by David Miller

Subject: Re: [PATCH net-next] genetlink: constify genl_err_attr() argument

From: Michal Kubecek <[email protected]>
Date: Tue, 28 Aug 2018 18:51:58 +0200 (CEST)

> genl_err_attr() sets netlink_ext_ack::bad_attr which is a pointer to const
> struct nlattr so make the attr argument also const.
>
> Signed-off-by: Michal Kubecek <[email protected]>

Applied.