2018-09-18 08:32:40

by zhong jiang

Subject: [PATCH] net: wan: remove redundant include

module.h already contained moduleparam.h, so it is safe to remove
the redundant include.

The issue is detected with the help of Coccinelle.

Signed-off-by: zhong jiang <[email protected]>
---
drivers/net/wan/c101.c | 1 -
drivers/net/wan/pci200syn.c | 1 -
2 files changed, 2 deletions(-)

diff --git a/drivers/net/wan/c101.c b/drivers/net/wan/c101.c
index 2371e07..91dbbde 100644
--- a/drivers/net/wan/c101.c
+++ b/drivers/net/wan/c101.c
@@ -24,7 +24,6 @@
#include <linux/string.h>
#include <linux/errno.h>
#include <linux/init.h>
-#include <linux/moduleparam.h>
#include <linux/netdevice.h>
#include <linux/hdlc.h>
#include <linux/delay.h>
diff --git a/drivers/net/wan/pci200syn.c b/drivers/net/wan/pci200syn.c
index 4e437c5..1f8a3f7 100644
--- a/drivers/net/wan/pci200syn.c
+++ b/drivers/net/wan/pci200syn.c
@@ -27,7 +27,6 @@
#include <linux/errno.h>
#include <linux/init.h>
#include <linux/ioport.h>
-#include <linux/moduleparam.h>
#include <linux/netdevice.h>
#include <linux/hdlc.h>
#include <linux/pci.h>
--
1.7.12.4

2018-09-19 03:09:55

by David Miller

Subject: Re: [PATCH] net: wan: remove redundant include

From: zhong jiang <[email protected]>
Date: Tue, 18 Sep 2018 16:19:35 +0800

> module.h already contained moduleparam.h, so it is safe to remove
> the redundant include.
>
> The issue is detected with the help of Coccinelle.
>
> Signed-off-by: zhong jiang <[email protected]>

Applied.