2018-09-21 10:37:53

by zhong jiang

[permalink] [raw]

Subject: [PATCH] soc: qcom: qdsp6: remove duplicated include from q6adm.c

---

We include wait.h twice in q6adm.c. it is unnecessary. hence remove
it. Further, order the include files as alphabet.

Signed-off-by: zhong jiang <[email protected]>
---
sound/soc/qcom/qdsp6/q6adm.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/sound/soc/qcom/qdsp6/q6adm.c b/sound/soc/qcom/qdsp6/q6adm.c
index 932c3eb..da24251 100644
--- a/sound/soc/qcom/qdsp6/q6adm.c
+++ b/sound/soc/qcom/qdsp6/q6adm.c
@@ -2,25 +2,24 @@
// Copyright (c) 2011-2017, The Linux Foundation. All rights reserved.
// Copyright (c) 2018, Linaro Limited

-#include <linux/slab.h>
-#include <linux/wait.h>
-#include <linux/kernel.h>
#include <linux/device.h>
-#include <linux/module.h>
-#include <linux/sched.h>
#include <linux/jiffies.h>
+#include <linux/kernel.h>
+#include <linux/kref.h>
+#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_platform.h>
-#include <linux/kref.h>
-#include <linux/wait.h>
-#include <linux/soc/qcom/apr.h>
#include <linux/platform_device.h>
+#include <linux/sched.h>
+#include <linux/slab.h>
+#include <linux/soc/qcom/apr.h>
+#include <linux/wait.h>
#include <sound/asound.h>
#include "q6adm.h"
#include "q6afe.h"
#include "q6core.h"
-#include "q6dsp-errno.h"
#include "q6dsp-common.h"
+#include "q6dsp-errno.h"

#define ADM_CMD_DEVICE_OPEN_V5 0x00010326
#define ADM_CMDRSP_DEVICE_OPEN_V5 0x00010329
--
1.7.12.4

2018-09-21 16:23:28

by Mark Brown

[permalink] [raw]

Subject: Re: [PATCH] soc: qcom: qdsp6: remove duplicated include from q6adm.c

---

On Fri, Sep 21, 2018 at 06:24:58PM +0800, zhong jiang wrote:
> We include wait.h twice in q6adm.c. it is unnecessary. hence remove
> it. Further, order the include files as alphabet.

Please use subject lines matching the style for the subsystem. This
makes it easier for people to identify relevant patches.

---

Attachments:

(No filename) (317.00 B)
signature.asc (499.00 B)
Download all attachments

2018-09-25 08:59:18

by zhong jiang

[permalink] [raw]

Subject: Re: [PATCH] soc: qcom: qdsp6: remove duplicated include from q6adm.c

---

On 2018/9/22 0:22, Mark Brown wrote:
> On Fri, Sep 21, 2018 at 06:24:58PM +0800, zhong jiang wrote:
>> We include wait.h twice in q6adm.c. it is unnecessary. hence remove
>> it. Further, order the include files as alphabet.
> Please use subject lines matching the style for the subsystem. This
> makes it easier for people to identify relevant patches.
Get it . Will notice . thanks

Sincerely,
zhong jiang