2018-10-03 12:02:02

by Gustavo A. R. Silva

[permalink] [raw]
Subject: [PATCH] ssb: chipcommon: fix fall-through annotation

Replace "Fallthough" with a proper "fall through" annotation.

This fix is part of the ongoing efforts to enabling
-Wimplicit-fallthrough

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/ssb/driver_chipcommon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ssb/driver_chipcommon.c b/drivers/ssb/driver_chipcommon.c
index 99a4656..3861cb6 100644
--- a/drivers/ssb/driver_chipcommon.c
+++ b/drivers/ssb/driver_chipcommon.c
@@ -425,7 +425,7 @@ void ssb_chipco_get_clockcontrol(struct ssb_chipcommon *cc,
*m = chipco_read32(cc, SSB_CHIPCO_CLOCK_M2);
break;
}
- /* Fallthough */
+ /* Fall through */
default:
*m = chipco_read32(cc, SSB_CHIPCO_CLOCK_SB);
}
--
2.7.4



2018-10-03 20:22:41

by Michael Büsch

[permalink] [raw]
Subject: Re: [PATCH] ssb: chipcommon: fix fall-through annotation

On Wed, 3 Oct 2018 14:01:02 +0200
"Gustavo A. R. Silva" <[email protected]> wrote:

> Replace "Fallthough" with a proper "fall through" annotation.
>
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/ssb/driver_chipcommon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ssb/driver_chipcommon.c b/drivers/ssb/driver_chipcommon.c
> index 99a4656..3861cb6 100644
> --- a/drivers/ssb/driver_chipcommon.c
> +++ b/drivers/ssb/driver_chipcommon.c
> @@ -425,7 +425,7 @@ void ssb_chipco_get_clockcontrol(struct ssb_chipcommon *cc,
> *m = chipco_read32(cc, SSB_CHIPCO_CLOCK_M2);
> break;
> }
> - /* Fallthough */
> + /* Fall through */
> default:
> *m = chipco_read32(cc, SSB_CHIPCO_CLOCK_SB);
> }

Acked-by: Michael Büsch <[email protected]>


--
Michael

Attachments:
(No filename) (849.00 B)
OpenPGP digital signature

2018-10-05 08:38:27

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ssb: chipcommon: fix fall-through annotation

"Gustavo A. R. Silva" <[email protected]> wrote:

> Replace "Fallthough" with a proper "fall through" annotation.
>
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> Acked-by: Michael Buesch <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

74aa3586c599 ssb: chipcommon: fix fall-through annotation

--
https://patchwork.kernel.org/patch/10624745/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches