2018-11-05 02:39:20

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] mtd: nand: drop kernel-doc notation for a deleted function parameter

From: Randy Dunlap <[email protected]>

Remove kernel-doc notation for a deleted function parameter to prevent
a kernel-doc warning:

../drivers/mtd/nand/raw/nand_base.c:603: warning: Excess function parameter 'mtd' description in 'panic_nand_wait'

Fixes: f1d46942e823 ("mtd: rawnand: Pass a nand_chip object to chip->waitfunc()")

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Boris Brezillon <[email protected]>
Cc: Miquel Raynal <[email protected]>
Cc: Richard Weinberger <[email protected]>
---

drivers/mtd/nand/raw/nand_base.c | 1 -
1 file changed, 1 deletion(-)

--- lnx-420-rc1.orig/drivers/mtd/nand/raw/nand_base.c
+++ lnx-420-rc1/drivers/mtd/nand/raw/nand_base.c
@@ -590,7 +590,6 @@ retry:

/**
* panic_nand_wait - [GENERIC] wait until the command is done
- * @mtd: MTD device structure
* @chip: NAND chip structure
* @timeo: timeout
*




2018-11-05 08:20:46

by Miquel Raynal

[permalink] [raw]
Subject: Re: [PATCH] mtd: nand: drop kernel-doc notation for a deleted function parameter

Hi Randy,

Subject prefix should be "mtd: rawnand:".

Randy Dunlap <[email protected]> wrote on Sun, 4 Nov 2018 18:38:35
-0800:

> From: Randy Dunlap <[email protected]>
>
> Remove kernel-doc notation for a deleted function parameter to prevent
> a kernel-doc warning:
>
> ../drivers/mtd/nand/raw/nand_base.c:603: warning: Excess function parameter 'mtd' description in 'panic_nand_wait'
>
> Fixes: f1d46942e823 ("mtd: rawnand: Pass a nand_chip object to chip->waitfunc()")
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Boris Brezillon <[email protected]>
> Cc: Miquel Raynal <[email protected]>
> Cc: Richard Weinberger <[email protected]>
> ---

Reviewed-by: Miquel Raynal <[email protected]>


Thanks,
Miquèl

2018-11-05 23:00:15

by Boris Brezillon

[permalink] [raw]
Subject: Re: [PATCH] mtd: nand: drop kernel-doc notation for a deleted function parameter

On Sun, 4 Nov 2018 18:38:35 -0800
Randy Dunlap <[email protected]> wrote:

> From: Randy Dunlap <[email protected]>
>
> Remove kernel-doc notation for a deleted function parameter to prevent
> a kernel-doc warning:
>
> ../drivers/mtd/nand/raw/nand_base.c:603: warning: Excess function parameter 'mtd' description in 'panic_nand_wait'
>
> Fixes: f1d46942e823 ("mtd: rawnand: Pass a nand_chip object to chip->waitfunc()")
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Boris Brezillon <[email protected]>
> Cc: Miquel Raynal <[email protected]>
> Cc: Richard Weinberger <[email protected]>

Queued to the fixes branch.

Thanks,

Boris

> ---
>
> drivers/mtd/nand/raw/nand_base.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- lnx-420-rc1.orig/drivers/mtd/nand/raw/nand_base.c
> +++ lnx-420-rc1/drivers/mtd/nand/raw/nand_base.c
> @@ -590,7 +590,6 @@ retry:
>
> /**
> * panic_nand_wait - [GENERIC] wait until the command is done
> - * @mtd: MTD device structure
> * @chip: NAND chip structure
> * @timeo: timeout
> *
>
>