2018-11-07 08:55:08

by Yi Wang

Subject: [PATCH 0/3] x86/cpu: fix some prototype warning

This series of patch fix some prototype warning because
of missing include file.

Yi Wang (3):
x86/cpu: fix prototype warning in cacheinfo.c
x86/cpu: fix prototype warning in scattered.c
x86/cpu: fix prototype warning in topology.c

arch/x86/kernel/cpu/cacheinfo.c | 1 +
arch/x86/kernel/cpu/scattered.c | 2 ++
arch/x86/kernel/cpu/topology.c | 2 ++
3 files changed, 5 insertions(+)

--
1.8.3.1

2018-11-07 08:59:38

by Yi Wang

Subject: [PATCH 1/3] x86/cpu: fix prototype warning in cacheinfo.c

Missing include file causes warning:
arch/x86/kernel/cpu/cacheinfo.c:647:6: warning: no previous prototype for ‘cacheinfo_amd_init_llc_id’ [-Wmissing-prototypes]
arch/x86/kernel/cpu/cacheinfo.c:686:6: warning: no previous prototype for ‘cacheinfo_hygon_init_llc_id’ [-Wmissing-prototypes]

Signed-off-by: Yi Wang <[email protected]>
---
arch/x86/kernel/cpu/cacheinfo.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/x86/kernel/cpu/cacheinfo.c b/arch/x86/kernel/cpu/cacheinfo.c
index dc1b934..5bafd93 100644
--- a/arch/x86/kernel/cpu/cacheinfo.c
+++ b/arch/x86/kernel/cpu/cacheinfo.c
@@ -19,6 +19,7 @@
#include <asm/cpufeature.h>
#include <asm/amd_nb.h>
#include <asm/smp.h>
+#include <asm/cacheinfo.h>

#include "cpu.h"

--
1.8.3.1

2018-11-07 09:00:19

by Yi Wang

Subject: [PATCH 2/3] x86/cpu: fix prototype warning in scattered.c

Missing include file causes warning:
arch/x86/kernel/cpu/scattered.c:37:6: warning: no previous prototype for ‘init_scattered_cpuid_features’ [-Wmissing-prototypes]
arch/x86/kernel/cpu/scattered.c:60:5: warning: no previous prototype for ‘get_scattered_cpuid_leaf’ [-Wmissing-prototypes]

Signed-off-by: Yi Wang <[email protected]>
---
arch/x86/kernel/cpu/scattered.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/x86/kernel/cpu/scattered.c b/arch/x86/kernel/cpu/scattered.c
index 772c219..5b6866f 100644
--- a/arch/x86/kernel/cpu/scattered.c
+++ b/arch/x86/kernel/cpu/scattered.c
@@ -9,6 +9,8 @@

#include <asm/apic.h>

+#include "cpu.h"
+
struct cpuid_bit {
u16 feature;
u8 reg;
--
1.8.3.1

2018-11-07 09:00:25

by Yi Wang

Subject: [PATCH 3/3] x86/cpu: fix prototype warning in topology.c

Missing include file causes warning:
arch/x86/kernel/cpu/topology.c:25:5: warning: no previous prototype for ‘detect_extended_topology_early’ [-Wmissing-prototypes]
arch/x86/kernel/cpu/topology.c:57:5: warning: no previous prototype for ‘detect_extended_topology’ [-Wmissing-prototypes]

Signed-off-by: Yi Wang <[email protected]>
---
arch/x86/kernel/cpu/topology.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/x86/kernel/cpu/topology.c b/arch/x86/kernel/cpu/topology.c
index 71ca064..8f6c784 100644
--- a/arch/x86/kernel/cpu/topology.c
+++ b/arch/x86/kernel/cpu/topology.c
@@ -10,6 +10,8 @@
#include <asm/pat.h>
#include <asm/processor.h>

+#include "cpu.h"
+
/* leaf 0xb SMT level */
#define SMT_LEVEL 0

--
1.8.3.1

2018-11-07 09:47:08

by Ingo Molnar

Subject: Re: [PATCH 0/3] x86/cpu: fix some prototype warning

* Yi Wang <[email protected]> wrote:

> This series of patch fix some prototype warning because
> of missing include file.
>
> Yi Wang (3):
> x86/cpu: fix prototype warning in cacheinfo.c
> x86/cpu: fix prototype warning in scattered.c
> x86/cpu: fix prototype warning in topology.c
>
> arch/x86/kernel/cpu/cacheinfo.c | 1 +
> arch/x86/kernel/cpu/scattered.c | 2 ++
> arch/x86/kernel/cpu/topology.c | 2 ++
> 3 files changed, 5 insertions(+)

Could you please submit this as a single patch?

Thanks,

Ingo