2018-11-07 20:42:57

by Colin King

Subject: [PATCH][i3c-next] i3c: fix incorrect update to max_read_ds

From: Colin Ian King <[email protected]>

Currently max_read_ds is being updated twice, which is incorrect.
The second assignment should be to max_write_ds instead. Fix this.

Detected by CoverityScan, CID#1475379 ("Unused value")

Fixes: 50cacdabeae1 ("i3c: Add core I3C infrastructure")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/i3c/master.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 68d6553dbd75..0ea7bb045fad 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -1093,7 +1093,7 @@ static int i3c_master_getmxds_locked(struct i3c_master_controller *master,
}

info->max_read_ds = getmaxds->maxrd;
- info->max_read_ds = getmaxds->maxwr;
+ info->max_write_ds = getmaxds->maxwr;
if (dest.payload.len == 5)
info->max_read_turnaround = getmaxds->maxrdturn[0] |
((u32)getmaxds->maxrdturn[1] << 8) |
--
2.19.1

2018-11-08 09:11:24

by Boris Brezillon

Subject: Re: [PATCH][i3c-next] i3c: fix incorrect update to max_read_ds

On Wed, 7 Nov 2018 20:42:08 +0000
Hi Colin,

Colin King <[email protected]> wrote:

> From: Colin Ian King <[email protected]>
>
> Currently max_read_ds is being updated twice, which is incorrect.
> The second assignment should be to max_write_ds instead. Fix this.
>
> Detected by CoverityScan, CID#1475379 ("Unused value")
>
> Fixes: 50cacdabeae1 ("i3c: Add core I3C infrastructure")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/i3c/master.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 68d6553dbd75..0ea7bb045fad 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -1093,7 +1093,7 @@ static int i3c_master_getmxds_locked(struct i3c_master_controller *master,
> }
>
> info->max_read_ds = getmaxds->maxrd;
> - info->max_read_ds = getmaxds->maxwr;
> + info->max_write_ds = getmaxds->maxwr;

Thanks for the fix.

Since the I3C driver is not merged yet, would you mind if I squash your
changes in the commit introducing the bug?

Regards,

Boris

2018-11-08 09:11:29

by Colin King

Subject: Re: [PATCH][i3c-next] i3c: fix incorrect update to max_read_ds

On 08/11/2018 09:09, Boris Brezillon wrote:
> On Wed, 7 Nov 2018 20:42:08 +0000
> Hi Colin,
>
> Colin King <[email protected]> wrote:
>
>> From: Colin Ian King <[email protected]>
>>
>> Currently max_read_ds is being updated twice, which is incorrect.
>> The second assignment should be to max_write_ds instead. Fix this.
>>
>> Detected by CoverityScan, CID#1475379 ("Unused value")
>>
>> Fixes: 50cacdabeae1 ("i3c: Add core I3C infrastructure")
>> Signed-off-by: Colin Ian King <[email protected]>
>> ---
>> drivers/i3c/master.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
>> index 68d6553dbd75..0ea7bb045fad 100644
>> --- a/drivers/i3c/master.c
>> +++ b/drivers/i3c/master.c
>> @@ -1093,7 +1093,7 @@ static int i3c_master_getmxds_locked(struct i3c_master_controller *master,
>> }
>>
>> info->max_read_ds = getmaxds->maxrd;
>> - info->max_read_ds = getmaxds->maxwr;
>> + info->max_write_ds = getmaxds->maxwr;
>
> Thanks for the fix.
>
> Since the I3C driver is not merged yet, would you mind if I squash your
> changes in the commit introducing the bug?

Sure, that's fine with me.

Colin
>
> Regards,
>
> Boris
>