2018-12-03 02:26:43

by Wen Yang

Subject: [PATCH v2] locktorture: style fix - spaces required around

This patch fixes the following checkpatch.pl errors:

ERROR: spaces required around that ':' (ctx:VxW)
+ torture_type, tag, cxt.debug_lock ? " [debug]": "",
^

Signed-off-by: Wen Yang <[email protected]>
CC: Davidlohr Bueso <[email protected]>
CC: "Paul E. McKenney" <[email protected]>
CC: Josh Triplett <[email protected]>
CC: Peter Zijlstra <[email protected]>
CC: Ingo Molnar <[email protected]>
CC: Will Deacon <[email protected]>
CC: [email protected]
---
kernel/locking/locktorture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
index cd95c01491d8..d1d8356b770a 100644
--- a/kernel/locking/locktorture.c
+++ b/kernel/locking/locktorture.c
@@ -790,7 +790,7 @@ lock_torture_print_module_parms(struct lock_torture_ops *cur_ops,
{
pr_alert("%s" TORTURE_FLAG
"--- %s%s: nwriters_stress=%d nreaders_stress=%d stat_interval=%d verbose=%d shuffle_interval=%d stutter=%d shutdown_secs=%d onoff_interval=%d onoff_holdoff=%d\n",
- torture_type, tag, cxt.debug_lock ? " [debug]": "",
+ torture_type, tag, cxt.debug_lock ? " [debug]" : "",
cxt.nrealwriters_stress, cxt.nrealreaders_stress, stat_interval,
verbose, shuffle_interval, stutter, shutdown_secs,
onoff_interval, onoff_holdoff);
--
2.19.1

2018-12-03 08:03:28

by Ingo Molnar

Subject: Re: [PATCH v2] locktorture: style fix - spaces required around

* Wen Yang <[email protected]> wrote:

> This patch fixes the following checkpatch.pl errors:
>
> ERROR: spaces required around that ':' (ctx:VxW)
> + torture_type, tag, cxt.debug_lock ? " [debug]": "",

There's literally 1 million checkpatch 'failures' in the kernel, so
unless we want to apply 1 million commits (we don't), please do such
cleanups as part of some real feature, simplification or optimization
work.

Thanks,

Ingo