2018-11-30 19:28:54

by Jarkko Sakkinen

[permalink] [raw]
Subject: [PATCH RFC 15/15] net: replace **** with a hug

In order to comply with the CoC, replace **** with a hug.

Signed-off-by: Jarkko Sakkinen <[email protected]>
---
net/core/skbuff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index a8217e221e19..8aadde6464a7 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -4093,7 +4093,7 @@ int skb_cow_data(struct sk_buff *skb, int tailbits, struct sk_buff **trailer)
skb_has_frag_list(skb1)) {
struct sk_buff *skb2;

- /* Fuck, we are miserable poor guys... */
+ /* Hug, we are miserable poor guys... */
if (ntail == 0)
skb2 = skb_copy(skb1, GFP_ATOMIC);
else
--
2.19.1



2018-12-03 10:16:12

by Phil Sutter

[permalink] [raw]
Subject: Re: [PATCH RFC 15/15] net: replace **** with a hug

On Fri, Nov 30, 2018 at 11:27:24AM -0800, Jarkko Sakkinen wrote:
> In order to comply with the CoC, replace **** with a hug.

This is incorrect: The patch doesn't replace '****', but 'fuck' instead.

> - /* Fuck, we are miserable poor guys... */
> + /* Hug, we are miserable poor guys... */

I fail to see the benefit from doing that. If I wrote: "Hug you you
hugging hug", you would still find it offensive as long as you know what
"hug" is supposed to translate into. And if you don't, you'll soon find
out.

A more constructive approach to replacing "fuck this and that" than
simply applying 's/fuck/whatever/' would be to provide details what
exactly is so bad about this and that. Of course that's not possible
without considerable effort, unlike your approach which doesn't alter
what is written but merely which words are used for it.

Cheers, Phil