2018-12-05 07:51:47

by Jiada Wang

Subject: [PATCH linux-next v3 7/7] clk: renesas: Add binding document for ADG

Add device tree bindings for Audio Clock Generator (ADG)
of R-Car Socs.

Signed-off-by: Jiada Wang <[email protected]>
---
.../clock/renesas,rcar-adg-clocks.txt | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
create mode 100644 Documentation/devicetree/bindings/clock/renesas,rcar-adg-clocks.txt

diff --git a/Documentation/devicetree/bindings/clock/renesas,rcar-adg-clocks.txt b/Documentation/devicetree/bindings/clock/renesas,rcar-adg-clocks.txt
new file mode 100644
index 000000000000..76fc4f8964e9
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/renesas,rcar-adg-clocks.txt
@@ -0,0 +1,24 @@
+* Renesas R-Car Audio Clock Generator (ADG)
+
+The Audio Clock Generator (ADG) is part of R-Car Audio module, it
+selects and supplies the necessary clock for the SSIU, EAVB-IF, SCU,
+ADSP or DTCP module. It also divides the frequency of the selected
+clock and sends it outside the chip.
+
+Required Properties:
+
+ - compatible: Must be one of
+ - "renesas,rcar_sound-gen1" for the R-Car GEN1 SoCs
+ - "renesas,rcar_sound-gen2" for the R-Car GEN2 SoCs
+ - "renesas,rcar_sound-gen3" for the R-Car GEN3 SoCs
+
+ - reg: Base address and length of the memory resource used by the ADG
+
+ - clocks: References to the parent clock S0D1.
+ - clock-names: ADG refer to its parent clock by name "adg".
+ - #clock-cells: Can be 0, 1 or 2
+ - When clock-cells = 0, ADG registers one fixed clock out
+ - When clock-cells = 1, ADG registers 3 fixed clock out
+ - When clock-cells = 2, ADG registers 3 fixed clock out and 8 AVB clocks
+ second clock specifier need to be 0 to refer to fixed clock out, need
+ to be 1 to refer to AVB clocks
--
2.19.2

2018-12-05 09:05:07

by Kuninori Morimoto

Subject: Re: [PATCH linux-next v3 7/7] clk: renesas: Add binding document for ADG

Hi Jiada

> Add device tree bindings for Audio Clock Generator (ADG)
> of R-Car Socs.
>
> Signed-off-by: Jiada Wang <[email protected]>
> ---
> .../clock/renesas,rcar-adg-clocks.txt | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/renesas,rcar-adg-clocks.txt

We want to have this document on rsnd.txt instead of
not-exist-driver file

/Documentation/devicetree/bindings/sound/renesas,rsnd.txt

Best regards
---
Kuninori Morimoto

2018-12-05 12:18:15

by Jiada Wang

Subject: Re: [PATCH linux-next v3 7/7] clk: renesas: Add binding document for ADG

Hi Morimoto-san

will rename dt bindings doc in next version

Thanks.
Jiada

On 2018/12/05 18:04, Kuninori Morimoto wrote:
> Hi Jiada
>
>> Add device tree bindings for Audio Clock Generator (ADG)
>> of R-Car Socs.
>>
>> Signed-off-by: Jiada Wang <[email protected]>
>> ---
>> .../clock/renesas,rcar-adg-clocks.txt | 24 +++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/renesas,rcar-adg-clocks.txt
> We want to have this document on rsnd.txt instead of
> not-exist-driver file
>
> /Documentation/devicetree/bindings/sound/renesas,rsnd.txt
>
> Best regards
> ---
> Kuninori Morimoto