2018-12-06 01:10:31

by Wen Yang

Subject: [PATCH] platform/x86: intel_ips: Remove unnecessary NULL check before debugfs_remove_recursive

debugfs_remove_recursive() accepts a NULL parameter and returns
immediately, there's no need for a NULL check in the caller.

This issue was detected with the help of Coccinelle.

Signed-off-by: Wen Yang <[email protected]>
CC: Darren Hart <[email protected]>
CC: Andy Shevchenko <[email protected]>
CC: [email protected]
CC: [email protected]
---
drivers/platform/x86/intel_ips.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
index 225638a1b09e..f8175b972537 100644
--- a/drivers/platform/x86/intel_ips.c
+++ b/drivers/platform/x86/intel_ips.c
@@ -1300,9 +1300,7 @@ static const struct file_operations ips_debugfs_ops = {

static void ips_debugfs_cleanup(struct ips_driver *ips)
{
- if (ips->debug_root)
- debugfs_remove_recursive(ips->debug_root);
- return;
+ debugfs_remove_recursive(ips->debug_root);
}

static void ips_debugfs_init(struct ips_driver *ips)
--
2.19.1

2018-12-06 02:39:53

by Andy Shevchenko

Subject: Re: [PATCH] platform/x86: intel_ips: Remove unnecessary NULL check before debugfs_remove_recursive

On Thu, Dec 6, 2018 at 3:09 AM Wen Yang <[email protected]> wrote:
>
> debugfs_remove_recursive() accepts a NULL parameter and returns
> immediately, there's no need for a NULL check in the caller.
>
> This issue was detected with the help of Coccinelle.
>

Thank you, similar patch is already in my queue.

> Signed-off-by: Wen Yang <[email protected]>
> CC: Darren Hart <[email protected]>
> CC: Andy Shevchenko <[email protected]>
> CC: [email protected]
> CC: [email protected]
> ---
> drivers/platform/x86/intel_ips.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
> index 225638a1b09e..f8175b972537 100644
> --- a/drivers/platform/x86/intel_ips.c
> +++ b/drivers/platform/x86/intel_ips.c
> @@ -1300,9 +1300,7 @@ static const struct file_operations ips_debugfs_ops = {
>
> static void ips_debugfs_cleanup(struct ips_driver *ips)
> {
> - if (ips->debug_root)
> - debugfs_remove_recursive(ips->debug_root);
> - return;
> + debugfs_remove_recursive(ips->debug_root);
> }
>
> static void ips_debugfs_init(struct ips_driver *ips)
> --
> 2.19.1
>


--
With Best Regards,
Andy Shevchenko