2018-12-06 10:23:08

by Wen Yang

Subject: [PATCH] PCI: endpoint: functions: Use kmemdup instead of duplicating its function

kmemdup has implemented the function that kmalloc() + memcpy().
We prefer to kmemdup rather than code opened implementation.

This issue was detected with the help of coccinelle.

Signed-off-by: Wen Yang <[email protected]>
CC: Bob Copeland <[email protected]>

CC: Kishon Vijay Abraham I <[email protected]>
CC: Lorenzo Pieralisi <[email protected]>
CC: Bjorn Helgaas <[email protected]>
CC: Gustavo Pimentel <[email protected]>
CC: Niklas Cassel <[email protected]>
CC: Greg Kroah-Hartman <[email protected]>
CC: Cyrille Pitchen <[email protected]>
CC: [email protected] (open list:PCI ENDPOINT SUBSYSTEM)
CC: [email protected] (open list)
---
drivers/pci/endpoint/functions/pci-epf-test.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
index 3e86fa3c7da3..6e42daa2a651 100644
--- a/drivers/pci/endpoint/functions/pci-epf-test.c
+++ b/drivers/pci/endpoint/functions/pci-epf-test.c
@@ -169,14 +169,12 @@ static int pci_epf_test_read(struct pci_epf_test *epf_test)
goto err_addr;
}

- buf = kzalloc(reg->size, GFP_KERNEL);
+ buf = kzalloc(src_addr, reg->size, GFP_KERNEL);
if (!buf) {
ret = -ENOMEM;
goto err_map_addr;
}

- memcpy(buf, src_addr, reg->size);
-
crc32 = crc32_le(~0, buf, reg->size);
if (crc32 != reg->checksum)
ret = -EIO;
--
2.19.1

2018-12-06 12:02:46

by Alan Douglas

Subject: RE: [PATCH] PCI: endpoint: functions: Use kmemdup instead of duplicating its function

Hi,

On 06 December 2018 10:21, Wen Yang wrote:
> kmemdup has implemented the function that kmalloc() + memcpy().
> We prefer to kmemdup rather than code opened implementation.
>
> This issue was detected with the help of coccinelle.
>
> Signed-off-by: Wen Yang <[email protected]>
> CC: Bob Copeland <[email protected]>
>
> CC: Kishon Vijay Abraham I <[email protected]>
> CC: Lorenzo Pieralisi <[email protected]>
> CC: Bjorn Helgaas <[email protected]>
> CC: Gustavo Pimentel <[email protected]>
> CC: Niklas Cassel <[email protected]>
> CC: Greg Kroah-Hartman <[email protected]>
> CC: Cyrille Pitchen <[email protected]>
> CC: [email protected] (open list:PCI ENDPOINT SUBSYSTEM)
> CC: [email protected] (open list)
> ---
> drivers/pci/endpoint/functions/pci-epf-test.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index 3e86fa3c7da3..6e42daa2a651 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -169,14 +169,12 @@ static int pci_epf_test_read(struct pci_epf_test *epf_test)
> goto err_addr;
> }
>
> - buf = kzalloc(reg->size, GFP_KERNEL);
> + buf = kzalloc(src_addr, reg->size, GFP_KERNEL);
Looks like a typo - kmemdup instead of kzalloc?

> if (!buf) {
> ret = -ENOMEM;
> goto err_map_addr;
> }
>
> - memcpy(buf, src_addr, reg->size);
> -
> crc32 = crc32_le(~0, buf, reg->size);
> if (crc32 != reg->checksum)
> ret = -EIO;
> --
> 2.19.1

Regards,
Alan

2018-12-11 14:23:51

by David Laight

Subject: RE: [PATCH] PCI: endpoint: functions: Use kmemdup instead of duplicating its function

From: Alan Douglas
> Sent: 06 December 2018 12:01
> Hi,
>
> On 06 December 2018 10:21, Wen Yang wrote:
> > kmemdup has implemented the function that kmalloc() + memcpy().
> > We prefer to kmemdup rather than code opened implementation.
...
> > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-
> test.c
> > index 3e86fa3c7da3..6e42daa2a651 100644
> > --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> > @@ -169,14 +169,12 @@ static int pci_epf_test_read(struct pci_epf_test *epf_test)
> > goto err_addr;
> > }
> >
> > - buf = kzalloc(reg->size, GFP_KERNEL);
> > + buf = kzalloc(src_addr, reg->size, GFP_KERNEL);
> Looks like a typo - kmemdup instead of kzalloc?

Which is why making butter (churning) like this is mostly pointless.
It is very easy to make silly mistakes.

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)