2018-11-28 22:30:53

by Alexandru Gagniuc

Subject: [PATCH] PCI: Add missing include to drivers/pci.h

This files makes use of definitions provided in <linux/pci.h>. This
only compiles when <linux/pci.h> is included beforehand, and creates
a nasty include dependency. Instead, just include the correct file.

Signed-off-by: Alexandru Gagniuc <[email protected]>
---
drivers/pci/pci.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index 662b7457db23..224d88634115 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -2,6 +2,8 @@
#ifndef DRIVERS_PCI_H
#define DRIVERS_PCI_H

+#include <linux/pci.h>
+
#define PCI_FIND_CAP_TTL 48

#define PCI_VSEC_ID_INTEL_TBT 0x1234 /* Thunderbolt */
--
2.17.1

2018-12-06 20:57:19

by Bjorn Helgaas

Subject: Re: [PATCH] PCI: Add missing include to drivers/pci.h

On Wed, Nov 28, 2018 at 04:28:04PM -0600, Alexandru Gagniuc wrote:
> This files makes use of definitions provided in <linux/pci.h>. This
> only compiles when <linux/pci.h> is included beforehand, and creates
> a nasty include dependency. Instead, just include the correct file.
>
> Signed-off-by: Alexandru Gagniuc <[email protected]>

Applied to pci/misc for v4.21, thanks!

> ---
> drivers/pci/pci.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> index 662b7457db23..224d88634115 100644
> --- a/drivers/pci/pci.h
> +++ b/drivers/pci/pci.h
> @@ -2,6 +2,8 @@
> #ifndef DRIVERS_PCI_H
> #define DRIVERS_PCI_H
>
> +#include <linux/pci.h>
> +
> #define PCI_FIND_CAP_TTL 48
>
> #define PCI_VSEC_ID_INTEL_TBT 0x1234 /* Thunderbolt */
> --
> 2.17.1
>