2018-12-18 16:25:46

by Michal Hocko

Subject: [PATCH] memory_hotplug: add missing newlines to debugging output

From: Michal Hocko <[email protected]>

pages_correctly_probed is missing new lines which means that the line is
not printed rightaway but it rather waits for additional printks.

Add \n to all three messages in pages_correctly_probed.

Fixes: b77eab7079d9 ("mm/memory_hotplug: optimize probe routine")
Signed-off-by: Michal Hocko <[email protected]>
---
drivers/base/memory.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 0e5985682642..b5ff45ab7967 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -207,15 +207,15 @@ static bool pages_correctly_probed(unsigned long start_pfn)
return false;

if (!present_section_nr(section_nr)) {
- pr_warn("section %ld pfn[%lx, %lx) not present",
+ pr_warn("section %ld pfn[%lx, %lx) not present\n",
section_nr, pfn, pfn + PAGES_PER_SECTION);
return false;
} else if (!valid_section_nr(section_nr)) {
- pr_warn("section %ld pfn[%lx, %lx) no valid memmap",
+ pr_warn("section %ld pfn[%lx, %lx) no valid memmap\n",
section_nr, pfn, pfn + PAGES_PER_SECTION);
return false;
} else if (online_section_nr(section_nr)) {
- pr_warn("section %ld pfn[%lx, %lx) is already online",
+ pr_warn("section %ld pfn[%lx, %lx) is already online\n",
section_nr, pfn, pfn + PAGES_PER_SECTION);
return false;
}
--
2.19.2

2018-12-18 16:36:35

by Oscar Salvador

Subject: Re: [PATCH] memory_hotplug: add missing newlines to debugging output

On Tue, Dec 18, 2018 at 05:23:07PM +0100, Michal Hocko wrote:
> From: Michal Hocko <[email protected]>

> Fixes: b77eab7079d9 ("mm/memory_hotplug: optimize probe routine")
> Signed-off-by: Michal Hocko <[email protected]>

Reviewed-by: Oscar Salvador <[email protected]>

> ---
> drivers/base/memory.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index 0e5985682642..b5ff45ab7967 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -207,15 +207,15 @@ static bool pages_correctly_probed(unsigned long start_pfn)
> return false;
>
> if (!present_section_nr(section_nr)) {
> - pr_warn("section %ld pfn[%lx, %lx) not present",
> + pr_warn("section %ld pfn[%lx, %lx) not present\n",
> section_nr, pfn, pfn + PAGES_PER_SECTION);
> return false;
> } else if (!valid_section_nr(section_nr)) {
> - pr_warn("section %ld pfn[%lx, %lx) no valid memmap",
> + pr_warn("section %ld pfn[%lx, %lx) no valid memmap\n",
> section_nr, pfn, pfn + PAGES_PER_SECTION);
> return false;
> } else if (online_section_nr(section_nr)) {
> - pr_warn("section %ld pfn[%lx, %lx) is already online",
> + pr_warn("section %ld pfn[%lx, %lx) is already online\n",
> section_nr, pfn, pfn + PAGES_PER_SECTION);
> return false;
> }
> --
> 2.19.2
>

--
Oscar Salvador
SUSE L3

2018-12-18 21:31:23

by Wei Yang

Subject: Re: [PATCH] memory_hotplug: add missing newlines to debugging output

On Tue, Dec 18, 2018 at 05:23:07PM +0100, Michal Hocko wrote:
>From: Michal Hocko <[email protected]>
>
>pages_correctly_probed is missing new lines which means that the line is
>not printed rightaway but it rather waits for additional printks.
>
>Add \n to all three messages in pages_correctly_probed.
>
>Fixes: b77eab7079d9 ("mm/memory_hotplug: optimize probe routine")
>Signed-off-by: Michal Hocko <[email protected]>

Reviewed-by: Wei Yang <[email protected]>

>---
> drivers/base/memory.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/base/memory.c b/drivers/base/memory.c
>index 0e5985682642..b5ff45ab7967 100644
>--- a/drivers/base/memory.c
>+++ b/drivers/base/memory.c
>@@ -207,15 +207,15 @@ static bool pages_correctly_probed(unsigned long start_pfn)
> return false;
>
> if (!present_section_nr(section_nr)) {
>- pr_warn("section %ld pfn[%lx, %lx) not present",
>+ pr_warn("section %ld pfn[%lx, %lx) not present\n",
> section_nr, pfn, pfn + PAGES_PER_SECTION);
> return false;
> } else if (!valid_section_nr(section_nr)) {
>- pr_warn("section %ld pfn[%lx, %lx) no valid memmap",
>+ pr_warn("section %ld pfn[%lx, %lx) no valid memmap\n",
> section_nr, pfn, pfn + PAGES_PER_SECTION);
> return false;
> } else if (online_section_nr(section_nr)) {
>- pr_warn("section %ld pfn[%lx, %lx) is already online",
>+ pr_warn("section %ld pfn[%lx, %lx) is already online\n",
> section_nr, pfn, pfn + PAGES_PER_SECTION);
> return false;
> }
>--
>2.19.2

--
Wei Yang
Help you, Help me