syscall_get_error() is required to be implemented on all
architectures in addition to already implemented syscall_get_nr(),
syscall_get_arguments(), syscall_get_return_value(), and
syscall_get_arch() functions in order to extend the generic
ptrace API with PTRACE_GET_SYSCALL_INFO request.
Cc: Paul Burton <[email protected]>
Cc: Ralf Baechle <[email protected]>
Cc: James Hogan <[email protected]>
Cc: Oleg Nesterov <[email protected]>
Cc: Andy Lutomirski <[email protected]>
Cc: Elvira Khabirova <[email protected]>
Cc: Eugene Syromyatnikov <[email protected]>
Cc: [email protected]
Signed-off-by: Dmitry V. Levin <[email protected]>
---
Notes:
v6: unchanged
v5: initial revision
arch/mips/include/asm/syscall.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/mips/include/asm/syscall.h b/arch/mips/include/asm/syscall.h
index 6cf8ffb5367e..04ab927ff47d 100644
--- a/arch/mips/include/asm/syscall.h
+++ b/arch/mips/include/asm/syscall.h
@@ -89,6 +89,12 @@ static inline unsigned long mips_get_syscall_arg(unsigned long *arg,
unreachable();
}
+static inline long syscall_get_error(struct task_struct *task,
+ struct pt_regs *regs)
+{
+ return regs->regs[7] ? -regs->regs[2] : 0;
+}
+
static inline long syscall_get_return_value(struct task_struct *task,
struct pt_regs *regs)
{
--
ldv
Hi Dmitry,
On Thu, Dec 13, 2018 at 08:23:02PM +0300, Dmitry V. Levin wrote:
> syscall_get_error() is required to be implemented on all
> architectures in addition to already implemented syscall_get_nr(),
> syscall_get_arguments(), syscall_get_return_value(), and
> syscall_get_arch() functions in order to extend the generic
> ptrace API with PTRACE_GET_SYSCALL_INFO request.
>
> Cc: Paul Burton <[email protected]>
> Cc: Ralf Baechle <[email protected]>
> Cc: James Hogan <[email protected]>
> Cc: Oleg Nesterov <[email protected]>
> Cc: Andy Lutomirski <[email protected]>
> Cc: Elvira Khabirova <[email protected]>
> Cc: Eugene Syromyatnikov <[email protected]>
> Cc: [email protected]
> Signed-off-by: Dmitry V. Levin <[email protected]>
Acked-by: Paul Burton <[email protected]>
Thanks,
Paul
Hi Paul,
On Thu, Dec 13, 2018 at 07:00:16PM +0000, Paul Burton wrote:
> Hi Dmitry,
>
> On Thu, Dec 13, 2018 at 08:23:02PM +0300, Dmitry V. Levin wrote:
> > syscall_get_error() is required to be implemented on all
> > architectures in addition to already implemented syscall_get_nr(),
> > syscall_get_arguments(), syscall_get_return_value(), and
> > syscall_get_arch() functions in order to extend the generic
> > ptrace API with PTRACE_GET_SYSCALL_INFO request.
> >
> > Cc: Paul Burton <[email protected]>
> > Cc: Ralf Baechle <[email protected]>
> > Cc: James Hogan <[email protected]>
> > Cc: Oleg Nesterov <[email protected]>
> > Cc: Andy Lutomirski <[email protected]>
> > Cc: Elvira Khabirova <[email protected]>
> > Cc: Eugene Syromyatnikov <[email protected]>
> > Cc: [email protected]
> > Signed-off-by: Dmitry V. Levin <[email protected]>
>
> Acked-by: Paul Burton <[email protected]>
As it looks like the whole series is going to be pinged for quite some time yet,
would you mind taking this patch into the mips tree?
Thanks,
--
ldv