2019-01-08 09:40:21

by Anders Roxell

Subject: [PATCH] selftests/networking: remove timestamping clean target

Commit cda261f421ba ("selftests: add txtimestamp kselftest") introduced
a warning:

Makefile:14: warning: overriding recipe for target 'clean'
../../lib.mk:137: warning: ignoring old recipe for target 'clean'

Theres no need for timestamping to have its own 'clean' target. The
lib.mk file's 'clean' target gets included to the timestamping Makefile
and that should be enough.

Fixes: cda261f421ba ("selftests: add txtimestamp kselftest")
Signed-off-by: Anders Roxell <[email protected]>
---
tools/testing/selftests/networking/timestamping/Makefile | 3 ---
1 file changed, 3 deletions(-)

diff --git a/tools/testing/selftests/networking/timestamping/Makefile b/tools/testing/selftests/networking/timestamping/Makefile
index 9050eeea5f5f..1de8bd8ccf5d 100644
--- a/tools/testing/selftests/networking/timestamping/Makefile
+++ b/tools/testing/selftests/networking/timestamping/Makefile
@@ -9,6 +9,3 @@ all: $(TEST_PROGS)
top_srcdir = ../../../../..
KSFT_KHDR_INSTALL := 1
include ../../lib.mk
-
-clean:
- rm -fr $(TEST_GEN_FILES)
--
2.20.1

2019-01-31 19:09:04

by Anders Roxell

Subject: Re: [PATCH] selftests/networking: remove timestamping clean target

On Tue, 8 Jan 2019 at 10:25, Anders Roxell <[email protected]> wrote:
>
> Commit cda261f421ba ("selftests: add txtimestamp kselftest") introduced
> a warning:
>
> Makefile:14: warning: overriding recipe for target 'clean'
> ../../lib.mk:137: warning: ignoring old recipe for target 'clean'
>
> Theres no need for timestamping to have its own 'clean' target. The
> lib.mk file's 'clean' target gets included to the timestamping Makefile
> and that should be enough.
>
> Fixes: cda261f421ba ("selftests: add txtimestamp kselftest")
> Signed-off-by: Anders Roxell <[email protected]>
> ---
> tools/testing/selftests/networking/timestamping/Makefile | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/networking/timestamping/Makefile b/tools/testing/selftests/networking/timestamping/Makefile
> index 9050eeea5f5f..1de8bd8ccf5d 100644
> --- a/tools/testing/selftests/networking/timestamping/Makefile
> +++ b/tools/testing/selftests/networking/timestamping/Makefile
> @@ -9,6 +9,3 @@ all: $(TEST_PROGS)
> top_srcdir = ../../../../..
> KSFT_KHDR_INSTALL := 1
> include ../../lib.mk
> -
> -clean:
> - rm -fr $(TEST_GEN_FILES)
> --
> 2.20.1
>

Does this make sense?

Cheers,
Anders