2019-01-19 21:52:04

by Luc Van Oostenryck

Subject: [PATCH] nft_counter: remove wrong __percpu of nft_counter_resest()'s arg

nft_counter_rest() has its first argument declared as
struct nft_counter_percpu_priv __percpu *priv
but this structure is not percpu (it only countains
a member 'counter' which is, correctly, a pointer to a
percpu struct nft_counter).

So, remove the '__percpu' from the argument's declaration.

Signed-off-by: Luc Van Oostenryck <[email protected]>
---
net/netfilter/nft_counter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/nft_counter.c b/net/netfilter/nft_counter.c
index a61d7edfc..1a6b06ce6 100644
--- a/net/netfilter/nft_counter.c
+++ b/net/netfilter/nft_counter.c
@@ -104,7 +104,7 @@ static void nft_counter_obj_destroy(const struct nft_ctx *ctx,
nft_counter_do_destroy(priv);
}

-static void nft_counter_reset(struct nft_counter_percpu_priv __percpu *priv,
+static void nft_counter_reset(struct nft_counter_percpu_priv *priv,
struct nft_counter *total)
{
struct nft_counter *this_cpu;
--
2.20.0

2019-01-28 10:21:00

by Pablo Neira Ayuso

Subject: Re: [PATCH] nft_counter: remove wrong __percpu of nft_counter_resest()'s arg

On Sat, Jan 19, 2019 at 10:50:24PM +0100, Luc Van Oostenryck wrote:
> nft_counter_rest() has its first argument declared as
> struct nft_counter_percpu_priv __percpu *priv
> but this structure is not percpu (it only countains
> a member 'counter' which is, correctly, a pointer to a
> percpu struct nft_counter).
>
> So, remove the '__percpu' from the argument's declaration.

Applied, thanks.