2019-01-22 10:26:24

by Suthikulpanit, Suravee

Subject: [PATCH] svm: Add warning message for AVIC IPI invalid target

From: Suravee Suthikulpanit <[email protected]>

Print warning message when IPI target ID is invalid due to one of
the following reasons:
* In logical mode: cluster > max_cluster (64)
* In physical mode: target > max_physical (512)
* Address is not present in the physical or logical ID tables

Signed-off-by: Suravee Suthikulpanit <[email protected]>
---
arch/x86/kvm/svm.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index a157ca5b6869..2aff835a65ed 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -4526,6 +4526,8 @@ static int avic_incomplete_ipi_interception(struct vcpu_svm *svm)
break;
}
case AVIC_IPI_FAILURE_INVALID_TARGET:
+ WARN_ONCE(1, "Invalid IPI target: index=%u, vcpu=%d, icr=%#0x:%#0x\n",
+ index, svm->vcpu.vcpu_id, icrh, icrl);
break;
case AVIC_IPI_FAILURE_INVALID_BACKING_PAGE:
WARN_ONCE(1, "Invalid backing page\n");
--
2.17.1

2019-01-25 17:52:29

by Paolo Bonzini

Subject: Re: [PATCH] svm: Add warning message for AVIC IPI invalid target

On 22/01/19 11:24, Suthikulpanit, Suravee wrote:
> From: Suravee Suthikulpanit <[email protected]>
>
> Print warning message when IPI target ID is invalid due to one of
> the following reasons:
> * In logical mode: cluster > max_cluster (64)
> * In physical mode: target > max_physical (512)
> * Address is not present in the physical or logical ID tables
>
> Signed-off-by: Suravee Suthikulpanit <[email protected]>
> ---
> arch/x86/kvm/svm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index a157ca5b6869..2aff835a65ed 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -4526,6 +4526,8 @@ static int avic_incomplete_ipi_interception(struct vcpu_svm *svm)
> break;
> }
> case AVIC_IPI_FAILURE_INVALID_TARGET:
> + WARN_ONCE(1, "Invalid IPI target: index=%u, vcpu=%d, icr=%#0x:%#0x\n",
> + index, svm->vcpu.vcpu_id, icrh, icrl);
> break;
> case AVIC_IPI_FAILURE_INVALID_BACKING_PAGE:
> WARN_ONCE(1, "Invalid backing page\n");
>

Queued, thanks.

Paolo