2019-02-15 17:03:08

by Mark D Rustad

[permalink] [raw]
Subject: [RFC PATCH 4.4] Documentation/network: reword kernel version reference

It seemed odd to say "since 4.17" in a 4.4 kernel. Consider
rewording the reference to indicate where in the stable series
it was introduced as well as where it originated.

Signed-off-by: Mark Rustad <[email protected]>

---

Does this brief elaboration add useful information? It seems to
me that someone using a particular series of stable kernels would
find this information to be helpful or at least potentially less
confusing to a non-developer.
---
Documentation/networking/ip-sysctl.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index 7c229f59016f..2fb35658d151 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -116,7 +116,7 @@ ipfrag_high_thresh - LONG INTEGER
Maximum memory used to reassemble IP fragments.

ipfrag_low_thresh - LONG INTEGER
- (Obsolete since linux-4.17)
+ (Obsolete since linux-4.4.174, backported from linux-4.17)
Maximum memory used to reassemble IP fragments before the kernel
begins to remove incomplete fragment queues to free up resources.
The kernel still accepts new fragments for defragmentation.



2019-02-18 01:37:58

by Sasha Levin

[permalink] [raw]
Subject: Re: [RFC PATCH 4.4] Documentation/network: reword kernel version reference

On Fri, Feb 15, 2019 at 08:19:55AM -0800, Mark Rustad wrote:
>It seemed odd to say "since 4.17" in a 4.4 kernel. Consider
>rewording the reference to indicate where in the stable series
>it was introduced as well as where it originated.
>
>Signed-off-by: Mark Rustad <[email protected]>
>
>---
>
>Does this brief elaboration add useful information? It seems to
>me that someone using a particular series of stable kernels would
>find this information to be helpful or at least potentially less
>confusing to a non-developer.
>---
> Documentation/networking/ip-sysctl.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
>index 7c229f59016f..2fb35658d151 100644
>--- a/Documentation/networking/ip-sysctl.txt
>+++ b/Documentation/networking/ip-sysctl.txt
>@@ -116,7 +116,7 @@ ipfrag_high_thresh - LONG INTEGER
> Maximum memory used to reassemble IP fragments.
>
> ipfrag_low_thresh - LONG INTEGER
>- (Obsolete since linux-4.17)
>+ (Obsolete since linux-4.4.174, backported from linux-4.17)
> Maximum memory used to reassemble IP fragments before the kernel
> begins to remove incomplete fragment queues to free up resources.
> The kernel still accepts new fragments for defragmentation.

Admittingly the stabke kernel rules do not allow documentation fixes,
but I can see how this can be confusing, and the fact that someone
actually hit it, wrote a patch and submitted it makes me want to ignore
that rule.

Queued, thank you!

--
Thanks,
Sasha