2019-03-14 09:04:26

by Arnd Bergmann

Subject: [PATCH] iio: pms7003: sleect IIO_TRIGGERED_BUFFER

Without IIO_TRIGGERED_BUFFER, this driver fails to link:

drivers/iio/chemical/pms7003.o: In function `pms7003_probe':
pms7003.c:(.text+0x21c): undefined reference to `devm_iio_triggered_buffer_setup'
pms7003.c:(.text+0x21c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `devm_iio_triggered_buffer_setup'

Fixes: a1d642266c14 ("iio: chemical: add support for Plantower PMS7003 sensor")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/iio/chemical/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
index d5d146e9e372..6f253092a523 100644
--- a/drivers/iio/chemical/Kconfig
+++ b/drivers/iio/chemical/Kconfig
@@ -64,6 +64,7 @@ config IAQCORE
config PMS7003
tristate "Plantower PMS7003 particulate matter sensor"
depends on SERIAL_DEV_BUS
+ select IIO_TRIGGERED_BUFFER
help
Say Y here to build support for the Plantower PMS7003 particulate
matter sensor.
--
2.20.0

2019-03-14 17:29:03

by Tomasz Duszynski

Subject: Re: [PATCH] iio: pms7003: sleect IIO_TRIGGERED_BUFFER

On Thu, Mar 14, 2019 at 10:00:52AM +0100, Arnd Bergmann wrote:
> Without IIO_TRIGGERED_BUFFER, this driver fails to link:

Good catch, thanks (btw, perhaps typo in subject can be fixed before
applying patch).

Acked-by: Tomasz Duszynski <[email protected]>

>
> drivers/iio/chemical/pms7003.o: In function `pms7003_probe':
> pms7003.c:(.text+0x21c): undefined reference to `devm_iio_triggered_buffer_setup'
> pms7003.c:(.text+0x21c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `devm_iio_triggered_buffer_setup'
>
> Fixes: a1d642266c14 ("iio: chemical: add support for Plantower PMS7003 sensor")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/iio/chemical/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
> index d5d146e9e372..6f253092a523 100644
> --- a/drivers/iio/chemical/Kconfig
> +++ b/drivers/iio/chemical/Kconfig
> @@ -64,6 +64,7 @@ config IAQCORE
> config PMS7003
> tristate "Plantower PMS7003 particulate matter sensor"
> depends on SERIAL_DEV_BUS
> + select IIO_TRIGGERED_BUFFER
> help
> Say Y here to build support for the Plantower PMS7003 particulate
> matter sensor.
> --
> 2.20.0
>

2019-03-16 16:37:25

by Jonathan Cameron

Subject: Re: [PATCH] iio: pms7003: sleect IIO_TRIGGERED_BUFFER

On Thu, 14 Mar 2019 18:27:35 +0100
Tomasz Duszynski <[email protected]> wrote:

> On Thu, Mar 14, 2019 at 10:00:52AM +0100, Arnd Bergmann wrote:
> > Without IIO_TRIGGERED_BUFFER, this driver fails to link:
>
> Good catch, thanks (btw, perhaps typo in subject can be fixed before
> applying patch).
>
> Acked-by: Tomasz Duszynski <[email protected]>
Applied to the fixes-togreg branch of iio.git with the typo
fixed.

Thanks!

Jonathan

>
> >
> > drivers/iio/chemical/pms7003.o: In function `pms7003_probe':
> > pms7003.c:(.text+0x21c): undefined reference to `devm_iio_triggered_buffer_setup'
> > pms7003.c:(.text+0x21c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `devm_iio_triggered_buffer_setup'
> >
> > Fixes: a1d642266c14 ("iio: chemical: add support for Plantower PMS7003 sensor")
> > Signed-off-by: Arnd Bergmann <[email protected]>
> > ---
> > drivers/iio/chemical/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
> > index d5d146e9e372..6f253092a523 100644
> > --- a/drivers/iio/chemical/Kconfig
> > +++ b/drivers/iio/chemical/Kconfig
> > @@ -64,6 +64,7 @@ config IAQCORE
> > config PMS7003
> > tristate "Plantower PMS7003 particulate matter sensor"
> > depends on SERIAL_DEV_BUS
> > + select IIO_TRIGGERED_BUFFER
> > help
> > Say Y here to build support for the Plantower PMS7003 particulate
> > matter sensor.
> > --
> > 2.20.0
> >