2019-03-01 20:03:03

by William Cohen

Subject: [PATCH] arm64/stacktrace: Export save_stack_trace_regs()

The ARM64 implements the save_stack_trace_regs function, but it is
unusable for any diagnostic tooling compiled as a kernel module due
the missing EXPORT_SYMBOL_GPL for the function. Export
save_stack_trace_regs() to align with other architectures such as
s390, openrisc, and powerpc. This is similar to the ARM64 export of
save_stack_trace_tsk() added in git commit e27c7fa015d6.

Signed-off-by: William Cohen <[email protected]>
---
arch/arm64/kernel/stacktrace.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c
index 1a29f2695ff2..d908b5e9e949 100644
--- a/arch/arm64/kernel/stacktrace.c
+++ b/arch/arm64/kernel/stacktrace.c
@@ -143,6 +143,7 @@ void save_stack_trace_regs(struct pt_regs *regs, struct stack_trace *trace)
if (trace->nr_entries < trace->max_entries)
trace->entries[trace->nr_entries++] = ULONG_MAX;
}
+EXPORT_SYMBOL_GPL(save_stack_trace_regs);

static noinline void __save_stack_trace(struct task_struct *tsk,
struct stack_trace *trace, unsigned int nosched)
--
2.20.1

2019-03-19 13:01:02

by Catalin Marinas

Subject: Re: [PATCH] arm64/stacktrace: Export save_stack_trace_regs()

On Fri, Mar 01, 2019 at 03:00:41PM -0500, William Cohen wrote:
> The ARM64 implements the save_stack_trace_regs function, but it is
> unusable for any diagnostic tooling compiled as a kernel module due
> the missing EXPORT_SYMBOL_GPL for the function. Export
> save_stack_trace_regs() to align with other architectures such as
> s390, openrisc, and powerpc. This is similar to the ARM64 export of
> save_stack_trace_tsk() added in git commit e27c7fa015d6.
>
> Signed-off-by: William Cohen <[email protected]>

Queued for 5.1-rc2. Thanks.

--
Catalin