2019-03-25 10:26:04

by Anders Roxell

Subject: [PATCH] rtc: sh: fix unused variable warning

When building the driver rtc/rtc-sh a warning about unused variable
shows up:

../drivers/rtc/rtc-sh.c: In function ‘sh_rtc_probe’:
../drivers/rtc/rtc-sh.c:472:18: warning: unused variable ‘r’ [-Wunused-variable]
struct rtc_time r;
^

Remove the declaration of the unused varable 'r'.

Fixes: 373f7f4bf4a5 ("rtc: sh: stop resetting time to epoch")
Signed-off-by: Anders Roxell <[email protected]>
---
drivers/rtc/rtc-sh.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/rtc-sh.c b/drivers/rtc/rtc-sh.c
index d72ee3a841ea..579b3ff5c644 100644
--- a/drivers/rtc/rtc-sh.c
+++ b/drivers/rtc/rtc-sh.c
@@ -469,7 +469,6 @@ static int __init sh_rtc_probe(struct platform_device *pdev)
{
struct sh_rtc *rtc;
struct resource *res;
- struct rtc_time r;
char clk_name[6];
int clk_id, ret;

--
2.20.1

2019-03-25 10:50:41

by Alexandre Belloni

Subject: Re: [PATCH] rtc: sh: fix unused variable warning

On 25/03/2019 11:24:53+0100, Anders Roxell wrote:
> When building the driver rtc/rtc-sh a warning about unused variable
> shows up:
>
> ../drivers/rtc/rtc-sh.c: In function ‘sh_rtc_probe’:
> ../drivers/rtc/rtc-sh.c:472:18: warning: unused variable ‘r’ [-Wunused-variable]
> struct rtc_time r;
> ^
>
> Remove the declaration of the unused varable 'r'.
>
> Fixes: 373f7f4bf4a5 ("rtc: sh: stop resetting time to epoch")
> Signed-off-by: Anders Roxell <[email protected]>
> ---
> drivers/rtc/rtc-sh.c | 1 -
> 1 file changed, 1 deletion(-)
>

Thanks, I've squashed it in the original commit as it is not yet in any
release and its hash may still change.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com