2019-04-26 08:45:15

by Vatsala Narang

Subject: [PATCH v2 2/2] staging: rtl8192u: ieee80211: Fix spelling mistake

Replace explicitely with explicitly to get rid of checkpatch warning.

Signed-off-by: Vatsala Narang <[email protected]>
---
Changes in v2:
-added this patch to patchset to fix spelling mistake.

drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
index 2044ae27b973..9631331b79d5 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
@@ -396,7 +396,8 @@ int ieee80211_wx_set_encode(struct ieee80211_device *ieee,
(*crypt)->priv);
sec.flags |= BIT(key);
/* This ensures a key will be activated if no key is
- * explicitely set */
+ * explicitly set
+ */
if (key == sec.active_key)
sec.flags |= SEC_ACTIVE_KEY;
ieee->tx_keyidx = key;
--
2.17.1

2019-04-26 15:33:04

by Gustavo A. R. Silva

Subject: Re: [PATCH v2 2/2] staging: rtl8192u: ieee80211: Fix spelling mistake

Hi Vatsala,

On 4/26/19 3:43 AM, Vatsala Narang wrote:
> Replace explicitely with explicitly to get rid of checkpatch warning.
>
> Signed-off-by: Vatsala Narang <[email protected]>
> ---
> Changes in v2:
> -added this patch to patchset to fix spelling mistake.
>

When you create a series, it is a good thing to include a cover letter,
in particular in cases like this, in which there is no v1 of this
patch. Notice that you have just created a v2 of a previously
non-existent series. This can create confusion for maintainers
were you addressing a more complex task.

I might be a bit picky here, but be sure that any extra time you
invest in the first stages as a kernel contributor will pay off
in the future. :)

Anyway, here is my

Acked-by: Gustavo A. R. Silva <[email protected]>

for both patches.

Thanks and keep contributing.
--
Gustavo

> drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> index 2044ae27b973..9631331b79d5 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> @@ -396,7 +396,8 @@ int ieee80211_wx_set_encode(struct ieee80211_device *ieee,
> (*crypt)->priv);
> sec.flags |= BIT(key);
> /* This ensures a key will be activated if no key is
> - * explicitely set */
> + * explicitly set
> + */
> if (key == sec.active_key)
> sec.flags |= SEC_ACTIVE_KEY;
> ieee->tx_keyidx = key;
>