2019-04-29 07:40:20

by Vatsala Narang

Subject: [PATCH] staging: vc04_services: bcm2835-camera: Modify return statement.

Modify return statement and remove the respective assignment.

Issue found by coccinelle.

Signed-off-by: Vatsala Narang <[email protected]>
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
index c9b6346111a5..cef6d5b758e8 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
@@ -1507,10 +1507,9 @@ static int set_camera_parameters(struct vchiq_mmal_instance *instance,
.use_stc_timestamp = MMAL_PARAM_TIMESTAMP_MODE_RAW_STC
};

- ret = vchiq_mmal_port_parameter_set(instance, &camera->control,
+ return vchiq_mmal_port_parameter_set(instance, &camera->control,
MMAL_PARAMETER_CAMERA_CONFIG,
&cam_config, sizeof(cam_config));
- return ret;
}

#define MAX_SUPPORTED_ENCODINGS 20
--
2.17.1

2019-04-30 13:03:29

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: vc04_services: bcm2835-camera: Modify return statement.

On Mon, Apr 29, 2019 at 01:06:58PM +0530, Vatsala Narang wrote:
> Modify return statement and remove the respective assignment.
>
> Issue found by coccinelle.
>
> Signed-off-by: Vatsala Narang <[email protected]>
> ---
> drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

You sent two different patches that did different things with the same
exact subject: line :(

Please make them more unique.

thanks,

greg k-h