Missing include:
drivers/spi/spi-zynqmp-gqspi.c:1025:13: error: implicit declaration of
function 'zynqmp_pm_get_eemi_ops'; did you mean
'zynqmp_process_dma_irq'? [-Werror=implicit-function-declaration]
Fixes: 3d0313786470a ('drivers: Defer probe if firmware is not ready')
Cc: Rajan Vaja <[email protected]>
Cc: Jolly Shah <[email protected]>
Cc: Michal Simek <[email protected]>
Signed-off-by: Olof Johansson <[email protected]>
---
drivers/spi/spi-zynqmp-gqspi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c
index d07b6f940f9f..9850a0efe85a 100644
--- a/drivers/spi/spi-zynqmp-gqspi.c
+++ b/drivers/spi/spi-zynqmp-gqspi.c
@@ -14,6 +14,7 @@
#include <linux/delay.h>
#include <linux/dma-mapping.h>
#include <linux/dmaengine.h>
+#include <linux/firmware/xlnx-zynqmp.h>
#include <linux/interrupt.h>
#include <linux/io.h>
#include <linux/module.h>
--
2.11.0
On 29. 04. 19 9:22, Olof Johansson wrote:
> Missing include:
> drivers/spi/spi-zynqmp-gqspi.c:1025:13: error: implicit declaration of
> function 'zynqmp_pm_get_eemi_ops'; did you mean
> 'zynqmp_process_dma_irq'? [-Werror=implicit-function-declaration]
>
> Fixes: 3d0313786470a ('drivers: Defer probe if firmware is not ready')
> Cc: Rajan Vaja <[email protected]>
> Cc: Jolly Shah <[email protected]>
> Cc: Michal Simek <[email protected]>
> Signed-off-by: Olof Johansson <[email protected]>
> ---
> drivers/spi/spi-zynqmp-gqspi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c
> index d07b6f940f9f..9850a0efe85a 100644
> --- a/drivers/spi/spi-zynqmp-gqspi.c
> +++ b/drivers/spi/spi-zynqmp-gqspi.c
> @@ -14,6 +14,7 @@
> #include <linux/delay.h>
> #include <linux/dma-mapping.h>
> #include <linux/dmaengine.h>
> +#include <linux/firmware/xlnx-zynqmp.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/module.h>
>
Acked-by: Michal Simek <[email protected]>
Thanks,
Michal
On Mon, Apr 29, 2019 at 09:22:46AM -0700, Olof Johansson wrote:
> Missing include:
> drivers/spi/spi-zynqmp-gqspi.c:1025:13: error: implicit declaration of
> function 'zynqmp_pm_get_eemi_ops'; did you mean
> 'zynqmp_process_dma_irq'? [-Werror=implicit-function-declaration]
>
> Fixes: 3d0313786470a ('drivers: Defer probe if firmware is not ready')
Please copy maintainers on patches so they aren't surprised when they
get mails saying they accepted patches they never heard of before!