2019-05-03 16:05:59

by Anders Roxell

Subject: [PATCH] rtc: imxdi: remove unused variable

This variable is no longer used and the compiler rightly complains that
it should be removed.

../drivers/rtc/rtc-imxdi.c: In function ‘dryice_rtc_set_alarm’:
../drivers/rtc/rtc-imxdi.c:633:16: warning: unused variable ‘now’ [-Wunused-variable]
unsigned long now;
^~~

Rework to remove the unused variable.

Fixes: 629d488a3eb6 ("rtc: imxdi: remove unnecessary check")
Signed-off-by: Anders Roxell <[email protected]>
---
drivers/rtc/rtc-imxdi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/rtc-imxdi.c b/drivers/rtc/rtc-imxdi.c
index 6342bc403645..3f3d652a0b0f 100644
--- a/drivers/rtc/rtc-imxdi.c
+++ b/drivers/rtc/rtc-imxdi.c
@@ -630,7 +630,6 @@ static int dryice_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm)
static int dryice_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm)
{
struct imxdi_dev *imxdi = dev_get_drvdata(dev);
- unsigned long now;
int rc;

/* write the new alarm time */
--
2.20.1

2019-05-03 16:08:55

by Alexandre Belloni

Subject: Re: [PATCH] rtc: imxdi: remove unused variable

On 03/05/2019 17:42:17+0200, Anders Roxell wrote:
> This variable is no longer used and the compiler rightly complains that
> it should be removed.
>
> ../drivers/rtc/rtc-imxdi.c: In function ‘dryice_rtc_set_alarm’:
> ../drivers/rtc/rtc-imxdi.c:633:16: warning: unused variable ‘now’ [-Wunused-variable]
> unsigned long now;
> ^~~
>
> Rework to remove the unused variable.
>
> Fixes: 629d488a3eb6 ("rtc: imxdi: remove unnecessary check")
> Signed-off-by: Anders Roxell <[email protected]>
> ---
> drivers/rtc/rtc-imxdi.c | 1 -
> 1 file changed, 1 deletion(-)
>
Applied, thanks.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com