2019-05-05 13:26:30

by Vatsala Narang

Subject: [PATCH v2 6/6] staging: rtl8723bs: core: Move logical operator to previous line.

Move logical operator to previous line to get rid of checkpatch warning.

Signed-off-by: Vatsala Narang <[email protected]>
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index 0b5bd047a552..b5e355de1199 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -5656,9 +5656,9 @@ static u8 chk_ap_is_alive(struct adapter *padapter, struct sta_info *psta)
);
#endif

- if ((sta_rx_data_pkts(psta) == sta_last_rx_data_pkts(psta))
- && sta_rx_beacon_pkts(psta) == sta_last_rx_beacon_pkts(psta)
- && sta_rx_probersp_pkts(psta) == sta_last_rx_probersp_pkts(psta)
+ if ((sta_rx_data_pkts(psta) == sta_last_rx_data_pkts(psta)) &&
+ sta_rx_beacon_pkts(psta) == sta_last_rx_beacon_pkts(psta) &&
+ sta_rx_probersp_pkts(psta) == sta_last_rx_probersp_pkts(psta)
) {
ret = false;
} else {
--
2.17.1

2019-05-13 10:22:22

by Greg Kroah-Hartman

Subject: Re: [PATCH v2 6/6] staging: rtl8723bs: core: Move logical operator to previous line.

On Sun, May 05, 2019 at 06:52:53PM +0530, Vatsala Narang wrote:
> Move logical operator to previous line to get rid of checkpatch warning.
>
> Signed-off-by: Vatsala Narang <[email protected]>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index 0b5bd047a552..b5e355de1199 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -5656,9 +5656,9 @@ static u8 chk_ap_is_alive(struct adapter *padapter, struct sta_info *psta)
> );
> #endif
>
> - if ((sta_rx_data_pkts(psta) == sta_last_rx_data_pkts(psta))
> - && sta_rx_beacon_pkts(psta) == sta_last_rx_beacon_pkts(psta)
> - && sta_rx_probersp_pkts(psta) == sta_last_rx_probersp_pkts(psta)
> + if ((sta_rx_data_pkts(psta) == sta_last_rx_data_pkts(psta)) &&
> + sta_rx_beacon_pkts(psta) == sta_last_rx_beacon_pkts(psta) &&
> + sta_rx_probersp_pkts(psta) == sta_last_rx_probersp_pkts(psta)

Odd, you should align these two lines, right?

> ) {

This should go on the previous line.

thanks,

greg k-h