2019-05-12 10:54:56

by Hariprasad Kelam

Subject: [PATCH v3] drivers: staging : wlan-ng : collect return status without variable

As caller rdev_set_default_key not particular about -EFAULT.
We can preserve the return value of prism2_domibset_uint32.

Signed-off-by: Hariprasad Kelam <[email protected]>
----
Changes in v2:
- remove masking of original return value with EFAULT
Changes in v3:
- merge patch v1 and v2 sothat it can be applied on linux-next
---
drivers/staging/wlan-ng/cfg80211.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index 8a862f7..eee1998 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -231,17 +231,9 @@ static int prism2_set_default_key(struct wiphy *wiphy, struct net_device *dev,
{
struct wlandevice *wlandev = dev->ml_priv;

- int err = 0;
- int result = 0;
-
- result = prism2_domibset_uint32(wlandev,
- DIDMIB_DOT11SMT_PRIVACYTABLE_WEPDEFAULTKEYID,
- key_index);
-
- if (result)
- err = -EFAULT;
-
- return err;
+ return prism2_domibset_uint32(wlandev,
+ DIDMIB_DOT11SMT_PRIVACYTABLE_WEPDEFAULTKEYID,
+ key_index);
}

static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
--
2.7.4

2019-05-13 09:56:11

by Dan Carpenter

Subject: Re: [PATCH v3] drivers: staging : wlan-ng : collect return status without variable

Thanks!

Reviewed-by: Dan Carpenter <[email protected]>

regards,
dan carpenter