2019-05-18 19:01:52

by Hariprasad Kelam

[permalink] [raw]
Subject: [PATCH] staging: erofs: fix Warning Use BUG_ON instead of if condition followed by BUG

fix below warning reported by coccicheck

drivers/staging/erofs/unzip_pagevec.h:74:2-5: WARNING: Use BUG_ON
instead of if condition followed by BUG.

Signed-off-by: Hariprasad Kelam <[email protected]>
---
drivers/staging/erofs/unzip_pagevec.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/erofs/unzip_pagevec.h b/drivers/staging/erofs/unzip_pagevec.h
index f37d8fd..0f61c54 100644
--- a/drivers/staging/erofs/unzip_pagevec.h
+++ b/drivers/staging/erofs/unzip_pagevec.h
@@ -70,8 +70,7 @@ z_erofs_pagevec_ctor_next_page(struct z_erofs_pagevec_ctor *ctor,
return tagptr_unfold_ptr(t);
}

- if (unlikely(nr >= ctor->nr))
- BUG();
+ BUG_ON(nr >= ctor->nr);

return NULL;
}
--
2.7.4