2019-05-18 18:27:52

by Hariprasad Kelam

Subject: [PATCH] staging: media: imx: fix Unneeded variable: "ret". Return "0"

fix below warning reported by coccichec

drivers/staging/media/imx/imx-media-capture.c:617:5-8: Unneeded
variable: "ret". Return "0" on line 630

Signed-off-by: Hariprasad Kelam <[email protected]>
---
drivers/staging/media/imx/imx-media-capture.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/media/imx/imx-media-capture.c b/drivers/staging/media/imx/imx-media-capture.c
index 9430c83..b678857 100644
--- a/drivers/staging/media/imx/imx-media-capture.c
+++ b/drivers/staging/media/imx/imx-media-capture.c
@@ -614,7 +614,6 @@ static int capture_release(struct file *file)
struct capture_priv *priv = video_drvdata(file);
struct video_device *vfd = priv->vdev.vfd;
struct vb2_queue *vq = &priv->q;
- int ret = 0;

mutex_lock(&priv->mutex);

@@ -627,7 +626,7 @@ static int capture_release(struct file *file)

v4l2_fh_release(file);
mutex_unlock(&priv->mutex);
- return ret;
+ return 0;
}

static const struct v4l2_file_operations capture_fops = {
--
2.7.4

2019-05-18 21:40:33

by Fabio Estevam

Subject: Re: [PATCH] staging: media: imx: fix Unneeded variable: "ret". Return "0"

On Sat, May 18, 2019 at 2:38 PM Hariprasad Kelam
<[email protected]> wrote:
>
> fix below warning reported by coccichec
>
> drivers/staging/media/imx/imx-media-capture.c:617:5-8: Unneeded
> variable: "ret". Return "0" on line 630
>
> Signed-off-by: Hariprasad Kelam <[email protected]>

Reviewed-by: Fabio Estevam <[email protected]>

Thanks