2019-05-27 14:03:33

by Yue Haibing

Subject: [PATCH -next] drivers: thermal: tsens: Change hw_id type to int in is_sensor_enabled

Sensor hw_id is int type other u32, is_sensor_enabled
should use int to compare, this fix smatch warning:

drivers/thermal/qcom/tsens-common.c:72
is_sensor_enabled() warn: unsigned 'hw_id' is never less than zero.

Fixes: 3e6a8fb33084 ("drivers: thermal: tsens: Add new operation to check if a sensor is enabled")
Signed-off-by: YueHaibing <[email protected]>
---
drivers/thermal/qcom/tsens-common.c | 2 +-
drivers/thermal/qcom/tsens.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
index 928e8e81ba69..5df4eed84535 100644
--- a/drivers/thermal/qcom/tsens-common.c
+++ b/drivers/thermal/qcom/tsens-common.c
@@ -64,7 +64,7 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *p1,
}
}

-bool is_sensor_enabled(struct tsens_priv *priv, u32 hw_id)
+bool is_sensor_enabled(struct tsens_priv *priv, int hw_id)
{
u32 val;
int ret;
diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h
index eefe3844fb4e..15264806f6a8 100644
--- a/drivers/thermal/qcom/tsens.h
+++ b/drivers/thermal/qcom/tsens.h
@@ -315,7 +315,7 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *pt1, u32 *pt2, u32 mo
int init_common(struct tsens_priv *priv);
int get_temp_tsens_valid(struct tsens_priv *priv, int i, int *temp);
int get_temp_common(struct tsens_priv *priv, int i, int *temp);
-bool is_sensor_enabled(struct tsens_priv *priv, u32 hw_id);
+bool is_sensor_enabled(struct tsens_priv *priv, int hw_id);

/* TSENS target */
extern const struct tsens_plat_data data_8960;
--
2.17.1

2019-05-29 02:46:43

by Eduardo Valentin

Subject: Re: [PATCH -next] drivers: thermal: tsens: Change hw_id type to int in is_sensor_enabled

YueHaibing,

On Mon, May 27, 2019 at 09:41:24PM +0800, YueHaibing wrote:
> Sensor hw_id is int type other u32, is_sensor_enabled
> should use int to compare, this fix smatch warning:
>
> drivers/thermal/qcom/tsens-common.c:72
> is_sensor_enabled() warn: unsigned 'hw_id' is never less than zero.
>
> Fixes: 3e6a8fb33084 ("drivers: thermal: tsens: Add new operation to check if a sensor is enabled")

Thanks for the patch, but we had to revert this commit which was
causing some issues. So, your patch is not applicable.

> Signed-off-by: YueHaibing <[email protected]>

Thank you anyways.

> ---
> drivers/thermal/qcom/tsens-common.c | 2 +-
> drivers/thermal/qcom/tsens.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
> index 928e8e81ba69..5df4eed84535 100644
> --- a/drivers/thermal/qcom/tsens-common.c
> +++ b/drivers/thermal/qcom/tsens-common.c
> @@ -64,7 +64,7 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *p1,
> }
> }
>
> -bool is_sensor_enabled(struct tsens_priv *priv, u32 hw_id)
> +bool is_sensor_enabled(struct tsens_priv *priv, int hw_id)
> {
> u32 val;
> int ret;
> diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h
> index eefe3844fb4e..15264806f6a8 100644
> --- a/drivers/thermal/qcom/tsens.h
> +++ b/drivers/thermal/qcom/tsens.h
> @@ -315,7 +315,7 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *pt1, u32 *pt2, u32 mo
> int init_common(struct tsens_priv *priv);
> int get_temp_tsens_valid(struct tsens_priv *priv, int i, int *temp);
> int get_temp_common(struct tsens_priv *priv, int i, int *temp);
> -bool is_sensor_enabled(struct tsens_priv *priv, u32 hw_id);
> +bool is_sensor_enabled(struct tsens_priv *priv, int hw_id);
>
> /* TSENS target */
> extern const struct tsens_plat_data data_8960;