2019-06-26 17:45:28

by Hariprasad Kelam

Subject: [PATCH] staging: rtl8723bs: hal: sdio_halinit: Remove set but unused varilable pHalData

Remove set but unsed variable pHalData in below functions

_InitOperationMode
SetHwReg8723BS

Signed-off-by: Hariprasad Kelam <[email protected]>
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 4d06ab7..9e8bbee 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -606,11 +606,9 @@ static void _initSdioAggregationSetting(struct adapter *padapter)

static void _InitOperationMode(struct adapter *padapter)
{
- struct hal_com_data *pHalData;
struct mlme_ext_priv *pmlmeext;
u8 regBwOpMode = 0;

- pHalData = GET_HAL_DATA(padapter);
pmlmeext = &padapter->mlmeextpriv;

/* 1 This part need to modified according to the rate set we filtered!! */
@@ -1413,7 +1411,6 @@ static void ReadAdapterInfo8723BS(struct adapter *padapter)
*/
static void SetHwReg8723BS(struct adapter *padapter, u8 variable, u8 *val)
{
- struct hal_com_data *pHalData;
u8 val8;

#if defined(CONFIG_WOWLAN) || defined(CONFIG_AP_WOWLAN)
@@ -1433,7 +1430,6 @@ static void SetHwReg8723BS(struct adapter *padapter, u8 variable, u8 *val)
#endif
#endif

- pHalData = GET_HAL_DATA(padapter);

switch (variable) {
case HW_VAR_SET_RPWM:
--
2.7.4

2019-06-27 06:40:27

by Dan Carpenter

Subject: Re: [PATCH] staging: rtl8723bs: hal: sdio_halinit: Remove set but unused varilable pHalData

On Wed, Jun 26, 2019 at 11:14:59PM +0530, Hariprasad Kelam wrote:
> @@ -1433,7 +1430,6 @@ static void SetHwReg8723BS(struct adapter *padapter, u8 variable, u8 *val)
> #endif
> #endif
>
> - pHalData = GET_HAL_DATA(padapter);
>
> switch (variable) {

We need to delete one of those blank lines or it introduces a new
checkpatch warning.

regards,
dan carpenter

2019-06-27 18:06:15

by Hariprasad Kelam

Subject: Re: [PATCH] staging: rtl8723bs: hal: sdio_halinit: Remove set but unused varilable pHalData

On Thu, Jun 27, 2019 at 09:38:35AM +0300, Dan Carpenter wrote:
> On Wed, Jun 26, 2019 at 11:14:59PM +0530, Hariprasad Kelam wrote:
> > @@ -1433,7 +1430,6 @@ static void SetHwReg8723BS(struct adapter *padapter, u8 variable, u8 *val)
> > #endif
> > #endif
> >
> > - pHalData = GET_HAL_DATA(padapter);
> >
> > switch (variable) {
>
> We need to delete one of those blank lines or it introduces a new
> checkpatch warning.
>
Yes thanks for correcting this . Will resend the patch.

Thanks,
Hariprasad k

> regards,
> dan carpenter
>